Addressed code review comments

Author: mmingyu

Doc/library/multiprocessing.rst

@@ -1952,9 +1952,9 @@ their parent process exits.  The manager classes are defined in the
       container object such as a shared list can contain other shared objects
       which will all be managed and synchronized by the :class:`SyncManager`.
 
-   .. versionchanged:: next
-      Add support for shared :class:`set`\s to :class:`multiprocessing.managers.SyncManager`
-      via :meth:`SyncManager.set() <multiprocessing.managers.SyncManager.set>`.
+   .. method:: set()
+
+      .. versionadded:: next
 
 .. class:: Namespace
 

Lib/multiprocessing/managers.py

@@ -1282,6 +1282,7 @@ class SyncManager(BaseManager):
 SyncManager.register('Value', Value, ValueProxy)
 SyncManager.register('Array', Array, ArrayProxy)
 SyncManager.register('Namespace', Namespace, NamespaceProxy)
+
 # types returned by methods of PoolProxy
 SyncManager.register('Iterator', proxytype=IteratorProxy, create_method=False)
 SyncManager.register('AsyncResult', create_method=False)

Lib/test/_test_multiprocessing.py

@@ -6455,6 +6455,7 @@ def _test_set_operator_symbols(cls, obj):
         obj |= {'d', 'e'}
         case.assertSetEqual(obj, {'a', 'b', 'c', 'd', 'e'})
         case.assertIsInstance(obj, multiprocessing.managers.SetProxy)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = {'a', 'b', 'd'} - obj
@@ -6464,6 +6465,7 @@ def _test_set_operator_symbols(cls, obj):
         obj -= {'a', 'b'}
         case.assertSetEqual(obj, {'c'})
         case.assertIsInstance(obj, multiprocessing.managers.SetProxy)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = {'b', 'c', 'd'} ^ obj
@@ -6473,35 +6475,35 @@ def _test_set_operator_symbols(cls, obj):
         obj ^= {'b', 'c', 'd'}
         case.assertSetEqual(obj, {'a', 'd'})
         case.assertIsInstance(obj, multiprocessing.managers.SetProxy)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = obj & {'b', 'c', 'd'}
         case.assertSetEqual(result, {'b', 'c'})
         result = {'b', 'c', 'd'} & obj
         case.assertSetEqual(result, {'b', 'c'})
         obj &= {'b', 'c', 'd'}
-        case.assertIsInstance(obj, multiprocessing.managers.SetProxy)
         case.assertSetEqual(obj, {'b', 'c'})
+        case.assertIsInstance(obj, multiprocessing.managers.SetProxy)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
-        case.assertGreater(obj, {'a'})
-        case.assertGreaterEqual(obj, {'a', 'b'})
-        case.assertLess(obj, {'a', 'b', 'c', 'd'})
-        case.assertLessEqual(obj, {'a', 'b', 'c'})
-        case.assertSetEqual({o for o in obj}, {'a', 'b', 'c'})
+        case.assertSetEqual(set(obj), {'a', 'b', 'c'})
 
     @classmethod
     def _test_set_operator_methods(cls, obj):
         case = unittest.TestCase()
         obj.add('d')
         case.assertIn('d', obj)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         copy_obj = obj.copy()
         case.assertSetEqual(copy_obj, obj)
         obj.remove('a')
         case.assertNotIn('a', obj)
         case.assertRaises(KeyError, obj.remove, 'a')
+
         obj.clear()
         obj.update(['a'])
         obj.discard('a')
@@ -6511,18 +6513,21 @@ def _test_set_operator_methods(cls, obj):
         obj.update(['a'])
         popped = obj.pop()
         case.assertNotIn(popped, obj)
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = obj.intersection({'b', 'c', 'd'})
         case.assertSetEqual(result, {'b', 'c'})
         obj.intersection_update({'b', 'c', 'd'})
         case.assertSetEqual(obj, {'b', 'c'})
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = obj.difference({'a', 'b'})
         case.assertSetEqual(result, {'c'})
         obj.difference_update({'a', 'b'})
         case.assertSetEqual(obj, {'c'})
+
         obj.clear()
         obj.update(['a', 'b', 'c'])
         result = obj.symmetric_difference({'b', 'c', 'd'})
@@ -6531,7 +6536,7 @@ def _test_set_operator_methods(cls, obj):
         case.assertSetEqual(obj, {'a', 'd'})
 
     @classmethod
-    def _test_set_miscellaneous(cls, obj):
+    def _test_set_comparisons(cls, obj):
         case = unittest.TestCase()
         obj.update(['a', 'b', 'c'])
         result = obj.union({'d', 'e'})
@@ -6542,14 +6547,18 @@ def _test_set_miscellaneous(cls, obj):
         case.assertFalse(obj.issubset({'a', 'b'}))
         case.assertTrue(obj.issuperset({'a', 'b'}))
         case.assertFalse(obj.issuperset({'a', 'b', 'd'}))
+        case.assertGreater(obj, {'a'})
+        case.assertGreaterEqual(obj, {'a', 'b'})
+        case.assertLess(obj, {'a', 'b', 'c', 'd'})
+        case.assertLessEqual(obj, {'a', 'b', 'c'})
 
     def test_set(self):
         o = self.manager.set()
         self.run_worker(self._test_set_operator_symbols, o)
         o = self.manager.set()
         self.run_worker(self._test_set_operator_methods, o)
         o = self.manager.set()
-        self.run_worker(self._test_set_miscellaneous, o)
+        self.run_worker(self._test_set_comparisons, o)
 
     def test_set_init(self):
         o = self.manager.set({'a', 'b', 'c'})