Petr's review

Author: AA-Turner

Include/internal/pycore_global_objects_fini_generated.h

@@ -475,6 +475,7 @@ struct _Py_global_strings {
         STRUCT_FOR_ID(format)
         STRUCT_FOR_ID(format_spec)
         STRUCT_FOR_ID(frame_buffer)
+        STRUCT_FOR_ID(free_threaded)
         STRUCT_FOR_ID(from_param)
         STRUCT_FOR_ID(fromlist)
         STRUCT_FOR_ID(fromtimestamp)
@@ -673,6 +674,7 @@ struct _Py_global_strings {
         STRUCT_FOR_ID(person)
         STRUCT_FOR_ID(pi_factory)
         STRUCT_FOR_ID(pid)
+        STRUCT_FOR_ID(pointer_bits)
         STRUCT_FOR_ID(policy)
         STRUCT_FOR_ID(pos)
         STRUCT_FOR_ID(pos1)

Include/internal/pycore_global_strings.h

@@ -741,8 +741,8 @@ def test_thread_info(self):
 
     def test_abi_info(self):
         info = sys.abi_info
-        info_keys = ['pointer_bits', 'free_threaded', 'debug', 'byteorder']
-        self.assertEqual(list(vars(info)), info_keys)
+        info_keys = {'pointer_bits', 'free_threaded', 'debug', 'byteorder'}
+        self.assertEqual(set(vars(info)), info_keys)
         pointer_bits = 64 if sys.maxsize > 2**32 else 32
         self.assertEqual(info.pointer_bits, pointer_bits)
         self.assertEqual(info.free_threaded,

Include/internal/pycore_runtime_init_generated.h

@@ -3656,7 +3656,7 @@ make_abi_info(void)
     if (value == NULL) {
         goto error;
     }
-    if (PyDict_SetItemString(abi_info, "pointer_bits", value) < 0) {
+    if (PyDict_SetItem(abi_info, &_Py_ID(pointer_bits), value) < 0) {
         goto error;
     }
     Py_DECREF(value);
@@ -3666,7 +3666,7 @@ make_abi_info(void)
 #else
     value = Py_False;
 #endif
-    if (PyDict_SetItemString(abi_info, "free_threaded", value) < 0) {
+    if (PyDict_SetItem(abi_info, &_Py_ID(free_threaded), value) < 0) {
         goto error;
     }
 
@@ -3675,7 +3675,7 @@ make_abi_info(void)
 #else
     value = Py_False;
 #endif
-    if (PyDict_SetItemString(abi_info, "debug", value) < 0) {
+    if (PyDict_SetItem(abi_info, &_Py_ID(debug), value) < 0) {
         goto error;
     }
 
@@ -3684,7 +3684,7 @@ make_abi_info(void)
 #else
     value = &_Py_ID(little);
 #endif
-    if (PyDict_SetItemString(abi_info, "byteorder", value) < 0) {
+    if (PyDict_SetItem(abi_info, &_Py_ID(byteorder), value) < 0) {
         goto error;
     }