Skip to content

Commit 8ec61b5

Browse files
committed
address _some_ correctness details in the test.
1 parent b3aa6cb commit 8ec61b5

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Lib/test/test_hashlib_fips.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,17 @@
55
#
66

77
import os
8+
import sys
89
import unittest
910

1011
OPENSSL_CONF_BACKUP = os.environ.get("OPENSSL_CONF")
1112

13+
1214
class HashLibFIPSTestCase(unittest.TestCase):
1315
@classmethod
1416
def setUpClass(cls):
17+
if sys.modules.get("_hashlib") or sys.modules.get("_ssl"):
18+
raise AssertionError("_hashlib or _ssl already imported, too late to change OPENSSL_CONF.")
1519
# This openssl.cnf mocks FIPS mode without any digest
1620
# loaded. It means all digests must raise ValueError when
1721
# usedforsecurity=True via either openssl or builtin
@@ -35,10 +39,10 @@ def setUp(self):
3539

3640
@classmethod
3741
def tearDownClass(cls):
38-
if OPENSSL_CONF_BACKUP:
42+
if OPENSSL_CONF_BACKUP is not None:
3943
os.environ["OPENSSL_CONF"] = OPENSSL_CONF_BACKUP
4044
else:
41-
del(os.environ["OPENSSL_CONF"])
45+
os.environ.pop("OPENSSL_CONF", None)
4246

4347
def test_algorithms_available(self):
4448
import hashlib

0 commit comments

Comments
 (0)