Skip to content

Commit 988d1c4

Browse files
committed
add test skips for WASI and android where file modes don't work well enough
1 parent 9371670 commit 988d1c4

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

Lib/test/test_pathlib/test_pathlib.py

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2493,6 +2493,10 @@ def my_mkdir(path, mode=0o777):
24932493
is_emscripten or is_wasi,
24942494
"umask is not implemented on Emscripten/WASI."
24952495
)
2496+
@unittest.skipIf(
2497+
sys.platform == "android",
2498+
"Android filesystem may not honor requested permissions."
2499+
)
24962500
def test_mkdir_parents_umask(self):
24972501
# Test that parent directories respect umask when parent_mode is not set
24982502
p = self.cls(self.base, 'umasktest', 'child')
@@ -2509,6 +2513,14 @@ def test_mkdir_parents_umask(self):
25092513
finally:
25102514
os.umask(old_mask)
25112515

2516+
@unittest.skipIf(
2517+
is_emscripten or is_wasi,
2518+
"umask is not implemented on Emscripten/WASI."
2519+
)
2520+
@unittest.skipIf(
2521+
sys.platform == "android",
2522+
"Android filesystem may not honor requested permissions."
2523+
)
25122524
def test_mkdir_with_parent_mode(self):
25132525
# Test the parent_mode parameter
25142526
p = self.cls(self.base, 'newdirPM', 'subdirPM')
@@ -2523,6 +2535,14 @@ def test_mkdir_with_parent_mode(self):
25232535
# Parent directory gets the parent_mode parameter
25242536
self.assertEqual(p.parent.stat().st_mode & 0o777, 0o750)
25252537

2538+
@unittest.skipIf(
2539+
is_emscripten or is_wasi,
2540+
"umask is not implemented on Emscripten/WASI."
2541+
)
2542+
@unittest.skipIf(
2543+
sys.platform == "android",
2544+
"Android filesystem may not honor requested permissions."
2545+
)
25262546
def test_mkdir_parent_mode_deep_hierarchy(self):
25272547
# Test parent_mode with deep directory hierarchy
25282548
p = self.cls(self.base, 'level1PM', 'level2PM', 'level3PM')
@@ -2542,6 +2562,10 @@ def test_mkdir_parent_mode_deep_hierarchy(self):
25422562
is_emscripten or is_wasi,
25432563
"umask is not implemented on Emscripten/WASI."
25442564
)
2565+
@unittest.skipIf(
2566+
sys.platform == "android",
2567+
"Android filesystem may not honor requested permissions."
2568+
)
25452569
def test_mkdir_parent_mode_overrides_umask(self):
25462570
# Test that parent_mode overrides umask for parent directories
25472571
p = self.cls(self.base, 'overridetest', 'child')
@@ -2559,6 +2583,14 @@ def test_mkdir_parent_mode_overrides_umask(self):
25592583
finally:
25602584
os.umask(old_mask)
25612585

2586+
@unittest.skipIf(
2587+
is_emscripten or is_wasi,
2588+
"umask is not implemented on Emscripten/WASI."
2589+
)
2590+
@unittest.skipIf(
2591+
sys.platform == "android",
2592+
"Android filesystem may not honor requested permissions."
2593+
)
25622594
def test_mkdir_parent_mode_same_as_mode(self):
25632595
# Test setting parent_mode same as mode
25642596
p = self.cls(self.base, 'samedirPM', 'subdirPM')

0 commit comments

Comments
 (0)