Apply suggestions from code review

sobolevn · ZeroIntensity · web-flow · commit 99ae55755732 · 2025-02-09T18:17:03.000+03:00
Co-authored-by: Peter Bierma &lt;zintensitydev@gmail.com&gt;
diff --git a/Misc/NEWS.d/next/Core and Builtins/2024-05-12-15-19-40.gh-issue-118965.Lr3qAz.rst b/Misc/NEWS.d/next/Core and Builtins/2024-05-12-15-19-40.gh-issue-118965.Lr3qAz.rst
@@ -1 +1 @@
-Added support for sharing ``NotImplemented`` singleton with subinterpreters.
+Added support for sharing :data:`NotImplemented` singleton between subinterpreters.
diff --git a/Python/crossinterp_data_lookup.h b/Python/crossinterp_data_lookup.h
@@ -440,7 +440,8 @@ _none_shared(PyThreadState *tstate, PyObject *obj,
 static PyObject *
 _new_notimplemented_object(_PyCrossInterpreterData *data)
 {
-    return Py_NewRef(Py_NotImplemented);
+    assert(_Py_IsImmortal(Py_NotImplemented));
+    return Py_NotImplemented;
 }
 
 static int

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Added support for sharing ``NotImplemented`` singleton with subinterpreters.
	`1`	+Added support for sharing :data:`NotImplemented` singleton between subinterpreters.
Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,8 @@ _none_shared(PyThreadState tstate, PyObject obj,`
`440`	`440`	`static PyObject *`
`441`	`441`	`_new_notimplemented_object(_PyCrossInterpreterData *data)`
`442`	`442`	`{`
`443`		`- return Py_NewRef(Py_NotImplemented);`
	`443`	`+ assert(_Py_IsImmortal(Py_NotImplemented));`
	`444`	`+ return Py_NotImplemented;`
`444`	`445`	`}`
`445`	`446`
`446`	`447`	`static int`