Invert the "not" arg for clarity

Author: brandtbucher

Include/internal/pycore_optimizer.h

@@ -276,7 +276,7 @@ extern bool _Py_uop_sym_is_immortal(JitOptSymbol *sym);
 extern JitOptSymbol *_Py_uop_sym_new_tuple(JitOptContext *ctx, int size, JitOptSymbol **args);
 extern JitOptSymbol *_Py_uop_sym_tuple_getitem(JitOptContext *ctx, JitOptSymbol *sym, int item);
 extern int _Py_uop_sym_tuple_length(JitOptSymbol *sym);
-extern JitOptSymbol *_Py_uop_sym_new_truthiness(JitOptContext *ctx, JitOptSymbol *value, bool not);
+extern JitOptSymbol *_Py_uop_sym_new_truthiness(JitOptContext *ctx, JitOptSymbol *value, bool truthy);
 
 extern void _Py_uop_abstractcontext_init(JitOptContext *ctx);
 extern void _Py_uop_abstractcontext_fini(JitOptContext *ctx);

Python/optimizer_bytecodes.c

@@ -392,14 +392,14 @@ dummy_func(void) {
 
     op(_TO_BOOL, (value -- res)) {
         if (!optimize_to_bool(this_instr, ctx, value, &res)) {
-            res = sym_new_truthiness(ctx, value, false);
+            res = sym_new_truthiness(ctx, value, true);
         }
     }
 
     op(_TO_BOOL_BOOL, (value -- res)) {
         if (!optimize_to_bool(this_instr, ctx, value, &res)) {
             sym_set_type(value, &PyBool_Type);
-            res = sym_new_truthiness(ctx, value, false);
+            res = sym_new_truthiness(ctx, value, true);
         }
     }
 
@@ -433,7 +433,7 @@ dummy_func(void) {
 
     op(_UNARY_NOT, (value -- res)) {
         sym_set_type(value, &PyBool_Type);
-        res = sym_new_truthiness(ctx, value, true);
+        res = sym_new_truthiness(ctx, value, false);
     }
 
     op(_COMPARE_OP, (left, right -- res)) {

Python/optimizer_cases.c.h

@@ -578,8 +578,10 @@ _Py_uop_sym_is_immortal(JitOptSymbol *sym)
 }
 
 JitOptSymbol *
-_Py_uop_sym_new_truthiness(JitOptContext *ctx, JitOptSymbol *value, bool not)
+_Py_uop_sym_new_truthiness(JitOptContext *ctx, JitOptSymbol *value, bool truthy)
 {
+    // It's clearer to invert this in the signature:
+    bool not = !truthy;
     if (value->tag == JIT_SYM_TRUTHINESS_TAG && value->truthiness.not == not) {
         return value;
     }