Properly check version in configure

Author: emmatyping

Modules/_zstd/_zstdmodule.h

@@ -12,10 +12,12 @@ Python module.
 #include "zdict.h"
 
 
-#define PYTHON_MINIMUM_SUPPORTED_ZSTD_VERSION 10400
+// if you update the minimum version, you should update the compile
+// check in configure.ac
+#define PYTHON_MINIMUM_SUPPORTED_ZSTD_VERSION 10405
 
 #if ZSTD_VERSION_NUMBER < PYTHON_MINIMUM_SUPPORTED_ZSTD_VERSION
-    #error "_zstd module requires zstd v1.4.0+"
+    #error "_zstd module requires zstd v1.4.5+"
 #endif
 
 /* Forward declaration of module state */

configure

@@ -5420,7 +5420,17 @@ PKG_CHECK_MODULES([LIBZSTD], [libzstd], [have_libzstd=yes], [
     CPPFLAGS="$CPPFLAGS $LIBZSTD_CFLAGS"
     LIBS="$LIBS $LIBZSTD_LIBS"
     AC_CHECK_HEADERS([zstd.h zdict.h], [
-      AC_CHECK_LIB([zstd], [ZDICT_finalizeDictionary], [have_libzstd=yes], [have_libzstd=no])
+      AC_CHECK_LIB([zstd], [ZDICT_finalizeDictionary], [
+        AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
+          #include "zstd.h"
+        ], [
+          // if you update the minimum version, you should update the compile
+          // check in Modules/_zstd/_zstdmodule.h
+          #if ZSTD_VERSION_NUMBER < 10405
+              #error "_zstd module requires zstd v1.4.5+"
+          #endif
+        ])], [have_libzstd=yes], [have_libzstd=no])
+      ], [have_libzstd=no])
     ], [have_libzstd=no])
     AS_VAR_IF([have_libzstd], [yes], [
       LIBZSTD_CFLAGS=${LIBZSTD_CFLAGS-""}