Skip to content

Commit a673930

Browse files
committed
apply code review requests
1 parent ad2d480 commit a673930

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

.github/actionlint.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
self-hosted-runner:
22
# Pending https://github.com/rhysd/actionlint/issues/533
3-
labels: ["windows-11-arm"]
3+
labels: ["windows-11-arm", "macos-15-intel"]
44

55
config-variables: null
66

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,13 @@ jobs:
202202
strategy:
203203
fail-fast: false
204204
matrix:
205-
# Cirrus and macos-14 are M1, macos-13 is default GHA Intel.
205+
# Cirrus and macos-14 are M1, macos-15 is default GHA Intel.
206206
# macOS 13 only runs tests against the GIL-enabled CPython.
207207
# Cirrus used for upstream, macos-14 for forks.
208208
os:
209209
- ghcr.io/cirruslabs/macos-runner:sonoma
210210
- macos-14
211-
- macos-13
211+
- macos-15
212212
is-fork: # only used for the exclusion trick
213213
- ${{ github.repository_owner != 'python' }}
214214
free-threading:
@@ -219,7 +219,7 @@ jobs:
219219
is-fork: true
220220
- os: macos-14
221221
is-fork: false
222-
- os: macos-13
222+
- os: macos-15
223223
free-threading: true
224224
uses: ./.github/workflows/reusable-macos.yml
225225
with:

.github/workflows/jit.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,9 @@ jobs:
108108
109109
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966.
110110
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same
111-
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes
112-
# the symlink to the pre-installed Python so that the Homebrew Python is used instead.
111+
# directory as the Homebrew Python, which causes the build to fail for macos-15
112+
# (was 13, see if bug still exists?) This line removes the symlink to the pre-installed Python so
113+
# that the Homebrew Python is used instead.
113114
- name: macOS
114115
if: runner.os == 'macOS'
115116
run: |

.github/workflows/reusable-macos.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ jobs:
6060
--prefix=/opt/python-dev \
6161
--with-openssl="$(brew --prefix [email protected])"
6262
- name: Build CPython
63-
if : ${{ inputs.free-threading || inputs.os != 'macos-13' }}
63+
if : ${{ inputs.free-threading || inputs.os != 'macos-15' }}
6464
run: gmake -j8
6565
- name: Build CPython for compiler warning check
66-
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }}
66+
if : ${{ !inputs.free-threading && inputs.os == 'macos-15' }}
6767
run: set -o pipefail; gmake -j8 --output-sync 2>&1 | tee compiler_output_macos.txt
6868
- name: Display build info
6969
run: make pythoninfo
7070
- name: Check compiler warnings
71-
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }}
71+
if : ${{ !inputs.free-threading && inputs.os == 'macos-15' }}
7272
run: >-
7373
python3 Tools/build/check_warnings.py
7474
--compiler-output-file-path=compiler_output_macos.txt

.github/workflows/tail-call.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
# runner: windows-2022
5959
- target: x86_64-apple-darwin/clang
6060
architecture: x86_64
61-
runner: macos-13
61+
runner: macos-15
6262
- target: aarch64-apple-darwin/clang
6363
architecture: aarch64
6464
runner: macos-14
@@ -103,7 +103,7 @@ jobs:
103103
104104
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966.
105105
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same
106-
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes
106+
# directory as the Homebrew Python, which causes the build to fail for macos-15. This line removes
107107
# the symlink to the pre-installed Python so that the Homebrew Python is used instead.
108108
# Note: when a new LLVM is released, the homebrew installation directory changes, so the builds will fail.
109109
# We either need to upgrade LLVM or change the directory being pointed to.

0 commit comments

Comments
 (0)