Skip to content

Commit a81eeaf

Browse files
miss-islingtonJacobCoffeewebknjazhugovk
authored
[3.14] gh-137638: Use macos-15-intel in GitHub Actions (GH-139154) (#139545)
Co-authored-by: Jacob Coffee <[email protected]> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
1 parent 22c6394 commit a81eeaf

File tree

5 files changed

+10
-21
lines changed

5 files changed

+10
-21
lines changed

.github/actionlint.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
self-hosted-runner:
22
# Pending https://github.com/rhysd/actionlint/issues/533
3-
labels: ["windows-11-arm"]
3+
# and https://github.com/rhysd/actionlint/issues/571
4+
labels: ["windows-11-arm", "macos-15-intel"]
45

56
config-variables: null
67

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,13 @@ jobs:
249249
strategy:
250250
fail-fast: false
251251
matrix:
252-
# Cirrus and macos-14 are M1, macos-13 is default GHA Intel.
252+
# Cirrus and macos-14 are M1, macos-15-intel is default GHA Intel.
253253
# macOS 13 only runs tests against the GIL-enabled CPython.
254254
# Cirrus used for upstream, macos-14 for forks.
255255
os:
256256
- ghcr.io/cirruslabs/macos-runner:sonoma
257257
- macos-14
258-
- macos-13
258+
- macos-15-intel
259259
is-fork: # only used for the exclusion trick
260260
- ${{ github.repository_owner != 'python' }}
261261
free-threading:
@@ -266,7 +266,7 @@ jobs:
266266
is-fork: true
267267
- os: macos-14
268268
is-fork: false
269-
- os: macos-13
269+
- os: macos-15-intel
270270
free-threading: true
271271
uses: ./.github/workflows/reusable-macos.yml
272272
with:

.github/workflows/jit.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
runner: windows-11-arm
7878
- target: x86_64-apple-darwin/clang
7979
architecture: x86_64
80-
runner: macos-13
80+
runner: macos-15-intel
8181
- target: aarch64-apple-darwin/clang
8282
architecture: aarch64
8383
runner: macos-14
@@ -102,15 +102,10 @@ jobs:
102102
./PCbuild/build.bat --experimental-jit ${{ matrix.debug && '-d' || '' }} -p ${{ matrix.architecture }}
103103
./PCbuild/rt.bat ${{ matrix.debug && '-d' || '' }} -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3
104104
105-
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966.
106-
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same
107-
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes
108-
# the symlink to the pre-installed Python so that the Homebrew Python is used instead.
109105
- name: macOS
110106
if: runner.os == 'macOS'
111107
run: |
112108
brew update
113-
find /usr/local/bin -lname '*/Library/Frameworks/Python.framework/*' -delete
114109
brew install llvm@${{ matrix.llvm }}
115110
export SDKROOT="$(xcrun --show-sdk-path)"
116111
# Set MACOSX_DEPLOYMENT_TARGET and -Werror=unguarded-availability to

.github/workflows/reusable-macos.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ jobs:
6060
--prefix=/opt/python-dev \
6161
--with-openssl="$(brew --prefix [email protected])"
6262
- name: Build CPython
63-
if : ${{ inputs.free-threading || inputs.os != 'macos-13' }}
63+
if : ${{ inputs.free-threading || inputs.os != 'macos-15-intel' }}
6464
run: gmake -j8
6565
- name: Build CPython for compiler warning check
66-
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }}
66+
if : ${{ !inputs.free-threading && inputs.os == 'macos-15-intel' }}
6767
run: set -o pipefail; gmake -j8 --output-sync 2>&1 | tee compiler_output_macos.txt
6868
- name: Display build info
6969
run: make pythoninfo
7070
- name: Check compiler warnings
71-
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }}
71+
if : ${{ !inputs.free-threading && inputs.os == 'macos-15-intel' }}
7272
run: >-
7373
python3 Tools/build/check_warnings.py
7474
--compiler-output-file-path=compiler_output_macos.txt

.github/workflows/tail-call.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
# runner: windows-2022
5959
- target: x86_64-apple-darwin/clang
6060
architecture: x86_64
61-
runner: macos-13
61+
runner: macos-15-intel
6262
- target: aarch64-apple-darwin/clang
6363
architecture: aarch64
6464
runner: macos-14
@@ -101,17 +101,10 @@ jobs:
101101
set LLVMInstallDir=C:\Program Files\LLVM
102102
./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }}
103103
104-
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966.
105-
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same
106-
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes
107-
# the symlink to the pre-installed Python so that the Homebrew Python is used instead.
108-
# Note: when a new LLVM is released, the homebrew installation directory changes, so the builds will fail.
109-
# We either need to upgrade LLVM or change the directory being pointed to.
110104
- name: Native macOS (release)
111105
if: runner.os == 'macOS'
112106
run: |
113107
brew update
114-
find /usr/local/bin -lname '*/Library/Frameworks/Python.framework/*' -delete
115108
brew install llvm@${{ matrix.llvm }}
116109
export SDKROOT="$(xcrun --show-sdk-path)"
117110
export PATH="/usr/local/opt/llvm@${{ matrix.llvm }}/bin:$PATH"

0 commit comments

Comments
 (0)