Skip to content

Commit aa811fe

Browse files
committed
Mark _PyList_FromStackRefStealOnSuccess as escaping
I think technically it's not escaping, because the only object that can be decrefed if allocation fails is an exact list, which cannot execute arbitrary code when it is destroyed. However, this seems less intrusive than trying to special cases objects in the assert in `_Py_Dealloc` that checks for non-null stackpointers and shouldn't matter for performance.
1 parent 2394419 commit aa811fe

File tree

5 files changed

+6
-3
lines changed

5 files changed

+6
-3
lines changed

Include/internal/pycore_opcode_metadata.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_metadata.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/executor_cases.c.h

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tools/cases_generator/analyzer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,6 @@ def has_error_without_pop(op: parser.CodeDef) -> bool:
632632
"_PyGen_GetGeneratorFromFrame",
633633
"_PyInterpreterState_GET",
634634
"_PyList_AppendTakeRef",
635-
"_PyList_FromStackRefStealOnSuccess",
636635
"_PyList_ITEMS",
637636
"_PyLong_CompactValue",
638637
"_PyLong_DigitCount",

0 commit comments

Comments
 (0)