Fix thread safety issue with cell_set_contents().

nascheme · nascheme · commit ab3af140a88b · 2024-11-26T11:44:04.000-08:00
diff --git a/Objects/cellobject.c b/Objects/cellobject.c
@@ -145,8 +145,9 @@ cell_get_contents(PyObject *self, void *closure)
 static int
 cell_set_contents(PyObject *self, PyObject *obj, void *Py_UNUSED(ignored))
 {
-    PyCellObject *op = _PyCell_CAST(self);
-    Py_XSETREF(op->ob_ref, Py_XNewRef(obj));
+    PyCellObject *cell = _PyCell_CAST(self);
+    Py_XINCREF(obj);
+    PyCell_SetTakeRef((PyCellObject *)cell, obj);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,9 @@ cell_get_contents(PyObject self, void closure)`
`145`	`145`	`static int`
`146`	`146`	`cell_set_contents(PyObject self, PyObject obj, void *Py_UNUSED(ignored))`
`147`	`147`	`{`
`148`		`- PyCellObject *op = _PyCell_CAST(self);`
`149`		`- Py_XSETREF(op->ob_ref, Py_XNewRef(obj));`
	`148`	`+ PyCellObject *cell = _PyCell_CAST(self);`
	`149`	`+ Py_XINCREF(obj);`
	`150`	`+ PyCell_SetTakeRef((PyCellObject *)cell, obj);`
`150`	`151`	`return 0;`
`151`	`152`	`}`
`152`	`153`