refactor traceback tests

Author: krisztian-gajdar

Lib/test/test_traceback.py

@@ -3803,12 +3803,8 @@ def test_traceback_header(self):
         self.assertEqual(list(exc.format()), ["Exception: haven\n"])
 
     def test_name_error_punctuation_with_suggestions(self):
-        def raise_mssage(message, name, name_from=None):
-            try:
-                raise NameError(message, name=name)
-            except NameError as e:
-                exc = traceback.TracebackException.from_exception(e)
-                return list(exc.format())[-1]
+        def format_error(message, name):
+            return self.format_error(NameError, message, name=name)
 
         test_cases = [
             ("a.", "time", "NameError: a. Did you forget to import 'time'?\n"),
@@ -3819,29 +3815,25 @@ def raise_mssage(message, name, name_from=None):
         ]
         for message, name, expected in test_cases:
             with self.subTest(message=message):
-                messsage = raise_mssage(message, name)
-                self.assertEqual(messsage, expected)
+                message = format_error(message, name)
+                self.assertEqual(message, expected)
 
-        with self.subTest("combined suggestion"):
-            messsage = raise_mssage("foo", "abc")
+        with self.subTest("stdlib module import suggestion"):
+            message = format_error("foo", "abc")
             expected_message = (
                 "NameError: foo. Did you mean: 'abs'? "
                 "Or did you forget to import 'abc'?\n"
             )
-            self.assertEqual(messsage, expected_message)
+            self.assertEqual(message, expected_message)
 
         with self.subTest("'did you mean' suggestion"):
-            messsage = raise_mssage("bar", "flaot")
+            message = format_error("bar", "flaot")
             expected_message = "NameError: bar. Did you mean: 'float'?\n"
-            self.assertEqual(messsage, expected_message)
+            self.assertEqual(message, expected_message)
 
     def test_import_error_punctuation_handling_with_suggestions(self):
-        def raise_mssage(message):
-            try:
-                raise ImportError(message, name="math", name_from="sinq")
-            except ImportError as e:
-                exc = traceback.TracebackException.from_exception(e)
-                return list(exc.format())[-1]
+        def format_error(message):
+            return self.format_error(ImportError, message, name="math", name_from="sinq")
 
         test_cases = [
             ("a.", "ImportError: a. Did you mean: 'sin'?\n"),
@@ -3851,8 +3843,8 @@ def raise_mssage(message):
         ]
         for message, expected in test_cases:
             with self.subTest(message=message):
-                messsage = raise_mssage(message)
-                self.assertEqual(messsage, expected)
+                message = format_error(message)
+                self.assertEqual(message, expected)
 
     @requires_debug_ranges()
     def test_print(self):
@@ -3891,6 +3883,14 @@ def test_dont_swallow_cause_or_context_of_falsey_exception(self):
         except FalseyException as e:
             self.assertIn(context_message, traceback.format_exception(e))
 
+    @staticmethod
+    def format_error(exc_type, exc_message, *args, **kwargs):
+        try:
+            raise exc_type(exc_message, *args, **kwargs)
+        except exc_type as e:
+            exc = traceback.TracebackException.from_exception(e)
+            return list(exc.format())[-1]
+
 
 class TestTracebackException_ExceptionGroups(unittest.TestCase):
     def setUp(self):