Fix subclassing HelpFormatter

Author: hugovk

Lib/argparse.py

@@ -2723,15 +2723,13 @@ def format_help(self):
         return formatter.format_help()
 
     def _get_formatter(self):
-        if isinstance(self.formatter_class, type) and issubclass(
-            self.formatter_class, HelpFormatter
-        ):
+        try:
             return self.formatter_class(
                 prog=self.prog,
                 prefix_chars=self.prefix_chars,
                 color=self.color,
             )
-        else:
+        except TypeError:
             return self.formatter_class(prog=self.prog)
 
     # =====================

Lib/test/test_argparse.py

@@ -5176,6 +5176,30 @@ class TestHelpTupleMetavarPositional(HelpTestCase):
     version = ''
 
 
+class TestHelpFormatter(HelpTestCase):
+    """Test the HelpFormatter"""
+
+    # Test subclassing the help formatter
+    class MyFormatter(argparse.HelpFormatter):
+        def __init__(self, prog) -> None:
+            super().__init__(prog)
+
+    parser_signature = Sig(
+        prog="PROG",
+        formatter_class=MyFormatter,
+        description="Test with subclassing the help formatter",
+    )
+    usage = '''\
+        usage: PROG [-h]
+        '''
+    help = usage + '''\
+
+        Test with subclassing the help formatter
+
+        options:
+          -h, --help  show this help message and exit
+        '''
+
 class TestHelpRawText(HelpTestCase):
     """Test the RawTextHelpFormatter"""
 

Misc/NEWS.d/next/Library/2025-05-08-16-28-05.gh-issue-133653.7cxHXN.rst

@@ -0,0 +1 @@
+Fix subclassing :meth:`argparse.HelpFormatter`. Patch by Hugo van Kemenade.