Add some tolerance to no-gil immortality

markshannon · markshannon · commit b1e2a339d440 · 2025-03-12T15:51:22.000Z
diff --git a/Include/refcount.h b/Include/refcount.h
@@ -287,7 +287,7 @@ static inline Py_ALWAYS_INLINE void Py_INCREF(PyObject *op)
     }
 #elif SIZEOF_VOID_P > 4
     PY_UINT32_T cur_refcnt = op->ob_refcnt;
-    if (((int32_t)cur_refcnt) < 0) {
+    if (cur_refcnt >= _Py_IMMORTAL_INITIAL_REFCNT) < 0) {
         // the object is immortal
         _Py_INCREF_IMMORTAL_STAT_INC();
         return;

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ static inline Py_ALWAYS_INLINE void Py_INCREF(PyObject *op)`
`287`	`287`	`}`
`288`	`288`	`#elif SIZEOF_VOID_P > 4`
`289`	`289`	`PY_UINT32_T cur_refcnt = op->ob_refcnt;`
`290`		`- if (((int32_t)cur_refcnt) < 0) {`
	`290`	`+ if (cur_refcnt >= _Py_IMMORTAL_INITIAL_REFCNT) < 0) {`
`291`	`291`	`// the object is immortal`
`292`	`292`	`_Py_INCREF_IMMORTAL_STAT_INC();`
`293`	`293`	`return;`