fix: address comments

Signed-off-by: yihong0618 <[email protected]>

Author: yihong0618

Lib/_pyrepl/console.py

@@ -47,8 +47,8 @@ class Event:
 
 @dataclass
 class Console(ABC):
-    posxy: tuple[int, int] = field(default=(0, 0), repr=False)
-    screen: list[str] = field(default_factory=list, repr=False)
+    posxy: tuple[int, int]
+    screen: list[str] = field(default_factory=list)
     height: int = 25
     width: int = 80
 

Lib/_pyrepl/reader.py

@@ -186,7 +186,7 @@ class Reader:
         that we're done.
     """
 
-    console: console.Console
+    console: console.Console = field(repr=False)
 
     ## state
     buffer: list[str] = field(default_factory=list)

Lib/test/test_pyrepl/test_pyrepl.py

@@ -26,7 +26,9 @@
     multiline_input,
     code_to_events,
 )
-from _pyrepl.console import Event
+from typing import IO
+
+from _pyrepl.console import Console, Event
 from _pyrepl._module_completer import (
     ImportParser,
     ModuleCompleter,
@@ -1416,22 +1418,91 @@ def test_dumb_terminal_exits_cleanly(self):
 
 class TestConsoleRepr(TestCase):
 
-    def test_console_repr_with_missing_attributes(self):
-        from _pyrepl.unix_console import UnixConsole
-        console = UnixConsole()
+    class _StubConsole(Console):
+        def __init__(
+            self,
+            f_in: int | IO[bytes] = 0,
+            f_out: int | IO[bytes] = 1,
+            term: str = "",
+            encoding: str = "",
+        ) -> None:
+            super().__init__(f_in, f_out, term, encoding)
+            self.height = 25
+            self.width = 80
+            self.screen = []
+
+        def refresh(self, screen: list[str], xy: tuple[int, int]) -> None:
+            pass
+
+        def prepare(self) -> None:
+            pass
+
+        def restore(self) -> None:
+            pass
+
+        def move_cursor(self, x: int, y: int) -> None:
+            pass
+
+        def set_cursor_vis(self, visible: bool) -> None:
+            pass
+
+        def getheightwidth(self) -> tuple[int, int]:
+            return self.height, self.width
+
+        def get_event(self, block: bool = True) -> Event | None:
+            return None
+
+        def push_char(self, char: int | bytes) -> None:
+            pass
+
+        def beep(self) -> None:
+            pass
+
+        def clear(self) -> None:
+            pass
+
+        def finish(self) -> None:
+            pass
+
+        def flushoutput(self) -> None:
+            pass
+
+        def forgetinput(self) -> None:
+            pass
+
+        def getpending(self) -> Event:
+            return Event("key", "", b"")
+
+        def wait(self, timeout: float | None = None) -> bool:
+            return False
+
+        def repaint(self) -> None:
+            pass
+
+        @property
+        def input_hook(self):
+            return None
+
+    def test_reader_repr_avoids_console_field(self):
+        console = self._StubConsole()
+        config = ReadlineConfig(readline_completer=None)
+
+        reader = ReadlineAlikeReader(console=console, config=config)
 
-        repr_str = repr(console)
+        repr_str = repr(reader)
 
         self.assertIsInstance(repr_str, str)
-        self.assertIn("UnixConsole", repr_str)
+        self.assertNotIn("console=", repr_str)
 
-    def test_readline_wrapper_repr_after_import(self):
-        import _pyrepl.readline
+    def test_wrapper_reader_repr_before_prepare(self):
+        with patch("_pyrepl.readline.Console", self._StubConsole), patch(
+            "_pyrepl.readline.os.dup",
+            side_effect=lambda fd: fd,
+        ):
+            wrapper = _ReadlineWrapper()
+            reader = wrapper.get_reader()
 
-        wrapper = _pyrepl.readline._wrapper
-        if wrapper is not None and wrapper.reader is not None:
-            repr_str = repr(wrapper.reader)
-            self.assertIsInstance(repr_str, str)
+        self.assertIsInstance(repr(reader), str)
 
 
 @skipUnless(pty, "requires pty")

Misc/NEWS.d/next/Library/2025-09-26-20-07-59.gh-issue-139349.ZJaeCq.rst

@@ -1,2 +1,2 @@
-Fix: make dataclass Console init right to avoid has no attribute 'posxy'
-error
+Avoid an ``AttributeError`` when calling :func:`repr` on
+``_pyrepl.readline._wrapper.reader`` before the console has been prepared.