PR review changes 🔨

Author: abdulrafey38

Lib/argparse.py

@@ -2541,14 +2541,23 @@ def _get_value(self, action, arg_string):
         return result
 
     def _check_value(self, action, value):
+        if not action.choices and isinstance(action.choices, list):
+            msg = 'Either add options in choices array or remove it'
+            raise ArgumentError(action, msg)
+
         # converted value must be one of the choices (if specified)
         if action.choices is not None and value not in action.choices:
-            closest_choice = _difflib.get_close_matches(value, action.choices)
+            try:
+                closest_choice = _difflib.get_close_matches(value, action.choices, 1)
+            except TypeError:
+                closest_choice = []
+
             args = {
                 'value': value,
                 'choices': ', '.join(map(repr, action.choices)),
             }
-            if closest_choice := closest_choice and closest_choice[0] or None:
+            if closest_choice:
+                closest_choice = closest_choice[0]
                 args['closest'] = closest_choice
                 msg = _('invalid choice: %(value)r, maybe you meant %(closest)r? '
                         '(choose from %(choices)s)')

Lib/test/test_argparse.py

@@ -2187,18 +2187,6 @@ def test_required_subparsers_no_destination_error(self):
         )
 
     def test_wrong_argument_subparsers_no_destination_error(self):
-        parser = ErrorRaisingArgumentParser()
-        subparsers = parser.add_subparsers(required=True)
-        subparsers.add_parser('foo')
-        subparsers.add_parser('bar')
-        with self.assertRaises(ArgumentParserError) as excinfo:
-            parser.parse_args(('test',))
-        self.assertRegex(
-            excinfo.exception.stderr,
-            r"error: argument {foo,bar}: invalid choice: 'baz' \(choose from 'foo', 'bar'\)\n$"
-        )
-
-    def test_wrong_argument_subparsers_no_destination_error_with_closest_choice_input(self):
         parser = ErrorRaisingArgumentParser()
         subparsers = parser.add_subparsers(required=True)
         subparsers.add_parser('foo')