Review

AA-Turner · AA-Turner · commit b971006c6015 · 2025-09-02T20:42:19.000+01:00
diff --git a/Modules/sha3module.c b/Modules/sha3module.c
@@ -471,6 +471,7 @@ SHA3_TYPE_SPEC(sha3_512_spec, "sha3_512", sha3_512_slots);
 static int
 sha3_shake_check_digest_length(Py_ssize_t length)
 {
+    assert(length >= 0);
     if ((size_t)length >= (1 << 29)) {
         /*
          * Raise OverflowError to match the semantics of OpenSSL SHAKE

Original file line number	Diff line number	Diff line change
`@@ -471,6 +471,7 @@ SHA3_TYPE_SPEC(sha3_512_spec, "sha3_512", sha3_512_slots);`
`471`	`471`	`static int`
`472`	`472`	`sha3_shake_check_digest_length(Py_ssize_t length)`
`473`	`473`	`{`
	`474`	`+ assert(length >= 0);`
`474`	`475`	`if ((size_t)length >= (1 << 29)) {`
`475`	`476`	`/*`
`476`	`477`	`* Raise OverflowError to match the semantics of OpenSSL SHAKE`