post review

Author: wiomoc

Lib/shlex.py

@@ -320,7 +320,7 @@ def join(split_command):
 def quote(s):
     """Return a shell-escaped version of the string *s*."""
     if not isinstance(s, str):
-        raise TypeError(f"expected str, not {type(s)!r}")
+        raise TypeError(f"expected string object, got {type(s).__name__!r}")
 
     if not s:
         return "''"

Lib/test/test_shlex.py

@@ -338,8 +338,8 @@ def testQuote(self):
         for u in unsafe:
             self.assertEqual(shlex.quote("test%s'name'" % u),
                              "'test%s'\"'\"'name'\"'\"''" % u)
-        with self.assertRaises(TypeError):
-            shlex.quote(42)
+        self.assertRaises(TypeError, shlex.quote, 42)
+        self.assertRaises(TypeError, shlex.quote, b"abc")
 
     def testJoin(self):
         for split_command, command in [

Misc/NEWS.d/next/Library/2025-09-12-01-01-05.gh-issue-138804.46ZukT.rst

@@ -1 +1,3 @@
-Check argument passed to ``shlex.quote`` to be a string
+Raise :exc:`TypeError` instead of :exc:`AttributeError` when an argument of
+incorrect type is passed to :func:`shlex.quote`. This restores the behavior of
+that function pre-3.14.