remove un-necessary PyErr_Occurred() assertions

picnixz · picnixz · commit bf48fc28f68a · 2025-01-06T11:01:11.000+01:00
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
@@ -1783,7 +1783,6 @@ _hashlib_HMAC_digest_impl(HMACobject *self)
     unsigned char digest[EVP_MAX_MD_SIZE];
     unsigned int digest_size = _hmac_digest_size(self);
     if (digest_size == 0) {
-        assert(PyErr_Occurred());
         return NULL;
     }
     int r = _hmac_digest(self, digest, digest_size);
@@ -1809,7 +1808,6 @@ _hashlib_HMAC_hexdigest_impl(HMACobject *self)
     unsigned char digest[EVP_MAX_MD_SIZE];
     unsigned int digest_size = _hmac_digest_size(self);
     if (digest_size == 0) {
-        assert(PyErr_Occurred());
         return NULL;
     }
     int r = _hmac_digest(self, digest, digest_size);
@@ -1824,7 +1822,6 @@ _hashlib_hmac_get_digest_size(HMACobject *self, void *closure)
 {
     unsigned int digest_size = _hmac_digest_size(self);
     if (digest_size == 0) {
-        assert(PyErr_Occurred());
         return NULL;
     }
     return PyLong_FromLong(digest_size);

Original file line number	Diff line number	Diff line change
`@@ -1783,7 +1783,6 @@ _hashlib_HMAC_digest_impl(HMACobject *self)`
`1783`	`1783`	`unsigned char digest[EVP_MAX_MD_SIZE];`
`1784`	`1784`	`unsigned int digest_size = _hmac_digest_size(self);`
`1785`	`1785`	`if (digest_size == 0) {`
`1786`		`- assert(PyErr_Occurred());`
`1787`	`1786`	`return NULL;`
`1788`	`1787`	`}`
`1789`	`1788`	`int r = _hmac_digest(self, digest, digest_size);`
`@@ -1809,7 +1808,6 @@ _hashlib_HMAC_hexdigest_impl(HMACobject *self)`
`1809`	`1808`	`unsigned char digest[EVP_MAX_MD_SIZE];`
`1810`	`1809`	`unsigned int digest_size = _hmac_digest_size(self);`
`1811`	`1810`	`if (digest_size == 0) {`
`1812`		`- assert(PyErr_Occurred());`
`1813`	`1811`	`return NULL;`
`1814`	`1812`	`}`
`1815`	`1813`	`int r = _hmac_digest(self, digest, digest_size);`
`@@ -1824,7 +1822,6 @@ _hashlib_hmac_get_digest_size(HMACobject self, void closure)`
`1824`	`1822`	`{`
`1825`	`1823`	`unsigned int digest_size = _hmac_digest_size(self);`
`1826`	`1824`	`if (digest_size == 0) {`
`1827`		`- assert(PyErr_Occurred());`
`1828`	`1825`	`return NULL;`
`1829`	`1826`	`}`
`1830`	`1827`	`return PyLong_FromLong(digest_size);`