Convert check to assert

encukou · encukou · commit bf49f61bd82c · 2024-06-20T13:48:04.000+02:00
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -15344,8 +15344,9 @@ intern_common(PyInterpreterState *interp, PyObject *s /* stolen */,
     /* Look in the global cache now. */
     {
         PyObject *r = (PyObject *)_Py_hashtable_get(INTERNED_STRINGS, s);
-        if (r != NULL && r != s) {
+        if (r != NULL) {
             assert(_Py_IsImmortal(r));
+            assert(r != s);  // r must be statically_allocated; s is not
             Py_DECREF(s);
             return Py_NewRef(r);
         }

Original file line number	Diff line number	Diff line change
`@@ -15344,8 +15344,9 @@ intern_common(PyInterpreterState interp, PyObject s /* stolen */,`
`15344`	`15344`	`/* Look in the global cache now. */`
`15345`	`15345`	`{`
`15346`	`15346`	`PyObject r = (PyObject )_Py_hashtable_get(INTERNED_STRINGS, s);`
`15347`		`- if (r != NULL && r != s) {`
	`15347`	`+ if (r != NULL) {`
`15348`	`15348`	`assert(_Py_IsImmortal(r));`
	`15349`	`+ assert(r != s); // r must be statically_allocated; s is not`
`15349`	`15350`	`Py_DECREF(s);`
`15350`	`15351`	`return Py_NewRef(r);`
`15351`	`15352`	`}`