gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 requirements (GH-128322)

zanieb · erlend-aasland · miss-islington · commit cd6a879638a2 · 2024-12-30T17:25:26.000Z
(cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Erlend E. Aasland <erlend@python.org>
diff --git a/Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst b/Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst
@@ -0,0 +1,3 @@
+Set ``LIBS`` instead of ``LDFLAGS`` when checking if :mod:`sqlite3` library
+functions are available. This fixes the ordering of linked libraries during
+checks, which was incorrect when using a statically linked ``libsqlite3``.
diff --git a/configure b/configure
diff --git a/configure.ac b/configure.ac
@@ -4185,7 +4185,7 @@ WITH_SAVE_ENV([
 dnl bpo-45774/GH-29507: The CPP check in AC_CHECK_HEADER can fail on FreeBSD,
 dnl hence CPPFLAGS instead of CFLAGS.
   CPPFLAGS="$CPPFLAGS $LIBSQLITE3_CFLAGS"
-  LDFLAGS="$LIBSQLITE3_LIBS $LDFLAGS"
+  LIBS="$LIBSQLITE3_LIBS $LIBS"
 
   AC_CHECK_HEADER([sqlite3.h], [
     have_sqlite3=yes

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Set ``LIBS`` instead of ``LDFLAGS`` when checking if :mod:`sqlite3` library
	`2`	`+functions are available. This fixes the ordering of linked libraries during`
	`3`	+checks, which was incorrect when using a statically linked ``libsqlite3``.