Apply review fixes

Co-authored-by: Victor Stinner <[email protected]>

Author: cmaloney

Lib/test/libregrtest/setup.py

@@ -8,6 +8,7 @@
 import unittest
 from test import support
 from test.support.os_helper import TESTFN_UNDECODABLE, FS_NONASCII
+from _colorize import can_colorize  # type: ignore[import-not-found]
 
 from .filter import set_match_tests
 from .runtests import RunTests
@@ -139,3 +140,6 @@ def setup_tests(runtests: RunTests) -> None:
         gc.set_threshold(runtests.gc_threshold)
 
     random.seed(runtests.random_seed)
+
+    if can_colorize(file=sys.stdout):
+        os.environ['FORCE_COLOR'] = "1"

Lib/test/libregrtest/single.py

@@ -2,13 +2,12 @@
 import gc
 import importlib
 import io
-import os
 import sys
 import time
 import traceback
 import unittest
 
-from _colorize import can_colorize, get_colors  # type: ignore[import-not-found]
+from _colorize import get_colors  # type: ignore[import-not-found]
 from test import support
 from test.support import threading_helper
 
@@ -275,9 +274,6 @@ def _runtest(result: TestResult, runtests: RunTests) -> None:
     output_on_failure = runtests.output_on_failure
     timeout = runtests.timeout
 
-    if can_colorize(file=sys.stdout):
-        os.environ['FORCE_COLOR'] = "1"
-
     if timeout is not None and threading_helper.can_start_thread:
         use_timeout = True
         faulthandler.dump_traceback_later(timeout, exit=True)

Lib/test/libregrtest/worker.py

@@ -33,7 +33,7 @@ def create_worker_process(runtests: WorkerRunTests, output_fd: int,
         env['TEMP'] = tmp_dir
         env['TMP'] = tmp_dir
 
-    # The subcommand is run with a temporary output which means it is not a tty
+    # The subcommand is run with a temporary output which means it is not a TTY
     # and won't auto-color. The test results are printed to stdout so if we can
     # color that have the subprocess use color.
     if can_colorize(file=sys.stdout):