Add update(**kwargs) method to types.SimpleNamespace

Author: Tomas Correia

Lib/test/test_types.py

@@ -21,6 +21,8 @@
 import unittest.mock
 import weakref
 import typing
+from types import SimpleNamespace 
+
 
 c_types = import_fresh_module('types', fresh=['_types'])
 py_types = import_fresh_module('types', blocked=['_types'])
@@ -2128,6 +2130,23 @@ class FakeSimpleNamespace(str):
             types.SimpleNamespace() > FakeSimpleNamespace()
         with self.assertRaises(TypeError):
             types.SimpleNamespace() >= FakeSimpleNamespace()
+    
+    def test_update_method(self):
+        ns = SimpleNamespace(a=1)
+        self.assertEqual(ns.a, 1)
+
+        ns.update(b=2, c=3)
+        self.assertEqual(ns.b, 2)
+        self.assertEqual(ns.c, 3)
+
+        # Overwriting existing key
+        ns.update(a=42)
+        self.assertEqual(ns.a, 42)
+
+        # No update with no kwargs
+        ns.update()
+        self.assertEqual(vars(ns), {'a': 42, 'b': 2, 'c': 3})
+
 
 
 class CoroutineTests(unittest.TestCase):

Objects/namespaceobject.c

@@ -245,14 +245,19 @@ namespace_replace(PyObject *self, PyObject *args, PyObject *kwargs)
     return result;
 }
 
+static PyObject *namespace_update(PyObject *self, PyObject *args, PyObject *kwds);
 
 static PyMethodDef namespace_methods[] = {
     {"__reduce__", namespace_reduce, METH_NOARGS,
      namespace_reduce__doc__},
     {"__replace__", _PyCFunction_CAST(namespace_replace), METH_VARARGS|METH_KEYWORDS,
      PyDoc_STR("__replace__($self, /, **changes)\n--\n\n"
         "Return a copy of the namespace object with new values for the specified attributes.")},
-    {NULL,         NULL}  // sentinel
+    {"update", (PyCFunction)(void(*)(void))namespace_update,
+     METH_VARARGS | METH_KEYWORDS,
+     PyDoc_STR("update(**kwargs)\n--\n\nUpdate namespace attributes from keyword arguments.")
+    },
+
 };
 
 
@@ -321,3 +326,28 @@ _PyNamespace_New(PyObject *kwds)
 
     return (PyObject *)ns;
 }
+
+#include "Python.h"
+
+static PyObject *
+namespace_update(PyObject *self, PyObject *args, PyObject *kwds)
+{
+    if (kwds == NULL) {
+        Py_RETURN_NONE;
+    }
+
+    PyObject *dict = PyObject_GetAttrString(self, "__dict__");
+    if (dict == NULL) {
+        return NULL;
+    }
+
+    int result = PyDict_Update(dict, kwds);
+    Py_DECREF(dict);
+
+    if (result < 0) {
+        return NULL;
+    }
+
+    Py_RETURN_NONE;
+}
+