Add histogram of the trace sizes

Author: diegorusso

Include/cpython/pystats.h

@@ -148,6 +148,7 @@ typedef struct _optimization_stats {
     uint64_t jit_data_size;
     uint64_t jit_padding_size;
     uint64_t jit_freed_memory_size;
+    uint64_t trace_total_memory_hist[_Py_UOP_HIST_SIZE];
 } OptimizationStats;
 
 typedef struct _rare_event_stats {

Python/jit.c

@@ -517,6 +517,7 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction trace[], siz
     OPT_STAT_ADD(jit_trampoline_size, state.trampolines.size);
     OPT_STAT_ADD(jit_data_size, data_size);
     OPT_STAT_ADD(jit_padding_size, padding);
+    OPT_HIST(total_size, trace_total_memory_hist);
     // Update the offsets of each instruction:
     for (size_t i = 0; i < length; i++) {
         state.instruction_starts[i] += (uintptr_t)memory;

Python/specialize.c

@@ -315,6 +315,8 @@ print_optimization_stats(FILE *out, OptimizationStats *stats)
     fprintf(out, "JIT data size: %" PRIu64 "\n", stats->jit_data_size);
     fprintf(out, "JIT padding size: %" PRIu64 "\n", stats->jit_padding_size);
     fprintf(out, "JIT freed memory size: %" PRIu64 "\n", stats->jit_freed_memory_size);
+
+    print_histogram(out, "Trace total memory size", stats->trace_total_memory_hist);
 }
 #endif
 

Tools/scripts/summarize_stats.py

@@ -1208,10 +1208,16 @@ def calc_jit_memory_table(stats: Stats) -> Rows:
             for label, (value, den) in jit_memory_stats.items()
         ]
 
-    def calc_histogram_table(key: str, den: str) -> RowCalculator:
+    def calc_histogram_table(key: str, den: str | None = None) -> RowCalculator:
         def calc(stats: Stats) -> Rows:
             histogram = stats.get_histogram(key)
-            denominator = stats.get(den)
+
+            if den:
+                denominator = stats.get(den)
+            else:
+                denominator = 0
+                for _, v in histogram:
+                    denominator += v
 
             rows: Rows = []
             last_non_zero = 0
@@ -1272,6 +1278,17 @@ def iter_optimization_tables(base_stats: Stats, head_stats: Stats | None = None)
                 )
             ],
         )
+        yield Section(
+            "JIT trace total memory histogram",
+            "",
+            [
+                Table(
+                    ("Size (bytes)", "Count", "Ratio:"),
+                    calc_histogram_table("Trace total memory size"),
+                    JoinMode.CHANGE_NO_SORT,
+                )
+            ],
+        )
         for name, den in [
             ("Trace length", "Optimization traces created"),
             ("Optimized trace length", "Optimization traces created"),