Skip to content

Commit d5c538f

Browse files
committed
Address review comments
1 parent cf1f908 commit d5c538f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Lib/email/_policybase.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
'compat32',
1616
]
1717

18-
# equivalent to pattern re.compile("[!-9;-~]+$")
18+
# validation regex from RFC 5322,equivalent to pattern re.compile("[!-9;-~]+$")
1919
valid_header_name_re = re.compile("[\041-\071\073-\176]+$")
2020

2121
def validate_header_name(name):

Lib/test/test_email/test_email.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,8 @@ def test_invalid_header_names(self):
742742
for policy in (email.policy.default, email.policy.compat32):
743743
for setter in (Message.__setitem__, Message.add_header):
744744
for name, value in invalid_headers:
745-
self.do_test_invalid_header_names(policy, setter, name, value)
745+
self.do_test_invalid_header_names(
746+
policy, setter,name, value)
746747

747748
def do_test_invalid_header_names(self, policy, setter, name, value):
748749
with self.subTest(policy=policy, setter=setter, name=name, value=value):
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
The :meth:`email.message.Message.add_header` method now validates header
2-
field names according to :rfc:`RFC 5322, Section 3.6.8 <5322#section-3.6.8>`
3-
and raises a :exc:`ValueError` if they contain invalid characters. A similar
4-
argument applies if headers are added through :meth:`Message.__setitem__
5-
<object.__setitem__>`.
1+
When headers are added to :meth:`email.message.Message` objects, either through
2+
:meth:`email.message.Message.__setitem__` or :meth:`email.message.Message.add_header`,
3+
the field name is now validated according to :rfc:`RFC 5322, Section 3.6.8 <5322#section-3.6.8>`
4+
and a :exc:`ValueError` is raised if the field name contains any invalid characters.

0 commit comments

Comments
 (0)