Update instr with proper return error handling

zydtiger · zydtiger · commit d868088f4126 · 2025-05-20T10:45:31.000-04:00
diff --git a/Modules/_cursesmodule.c b/Modules/_cursesmodule.c
@@ -2094,9 +2094,12 @@ PyCursesWindow_InStr(PyObject *op, PyObject *args)
     }
 
     if (rtn == ERR) {
-        _PyBytes_Resize(&result, 0);
-    } else {
-        _PyBytes_Resize(&result, rtn);
+      Py_DECREF(result);
+      return Py_GetConstant(Py_CONSTANT_EMPTY_BYTES);
+    }
+
+    if (_PyBytes_Resize(&result, rtn) < 0) {
+        return NULL;
     }
 
     return result;

Original file line number	Diff line number	Diff line change
`@@ -2094,9 +2094,12 @@ PyCursesWindow_InStr(PyObject op, PyObject args)`
`2094`	`2094`	`}`
`2095`	`2095`
`2096`	`2096`	`if (rtn == ERR) {`
`2097`		`- _PyBytes_Resize(&result, 0);`
`2098`		`- } else {`
`2099`		`- _PyBytes_Resize(&result, rtn);`
	`2097`	`+ Py_DECREF(result);`
	`2098`	`+ return Py_GetConstant(Py_CONSTANT_EMPTY_BYTES);`
	`2099`	`+ }`
	`2100`	`+`
	`2101`	`+ if (_PyBytes_Resize(&result, rtn) < 0) {`
	`2102`	`+ return NULL;`
`2100`	`2103`	`}`
`2101`	`2104`
`2102`	`2105`	`return result;`