Various pr feedbacks

Drop extra prefix on tests, fix formating on gh issue file

Separate a couple operations into different lines

Author: csm10495

Doc/library/concurrent.futures.rst

@@ -430,7 +430,7 @@ to a :class:`ProcessPoolExecutor` will result in deadlock.
    .. method:: kill_workers()
 
       Attempt to kill all living worker processes immediately by calling
-      :meth:`Process.terminate <multiprocessing.Process.kill>` on each of them.
+      :meth:`Process.kill <multiprocessing.Process.kill>` on each of them.
       Internally, it will also call :meth:`Executor.shutdown` to ensure that all
       other resources associated with the executor are freed.
 

Lib/concurrent/futures/process.py

@@ -874,7 +874,7 @@ def _terminate_or_kill_workers(self, operation):
         submitted).
         """
         if operation not in _TERMINATE_OR_KILL_OPERATION:
-            raise ValueError(f"Unsupported operation: {operation}")
+            raise ValueError(f"Unsupported operation: {operation!r}")
 
         processes = {}
         if self._processes:

Lib/test/test_concurrent_futures/test_process_pool.py

@@ -233,28 +233,28 @@ def mock_start_new_thread(func, *args, **kwargs):
                     list(executor.map(mul, [(2, 3)] * 10))
             executor.shutdown()
 
-    def test_process_pool_executor_terminate_workers(self):
+    def test_terminate_workers(self):
         with futures.ProcessPoolExecutor(max_workers=1) as executor:
             executor._terminate_or_kill_workers = unittest.mock.Mock()
             executor.terminate_workers()
 
         executor._terminate_or_kill_workers.assert_called_once_with(operation=futures.process._TERMINATE)
 
-    def test_process_pool_executor_kill_workers(self):
+    def test_kill_workers(self):
         with futures.ProcessPoolExecutor(max_workers=1) as executor:
             executor._terminate_or_kill_workers = unittest.mock.Mock()
             executor.kill_workers()
 
         executor._terminate_or_kill_workers.assert_called_once_with(operation=futures.process._KILL)
 
-    def test_process_pool_executor_terminate_or_kill_workers_invalid_op(self):
+    def test_terminate_or_kill_workers_invalid_op(self):
         with futures.ProcessPoolExecutor(max_workers=1) as executor:
             self.assertRaises(ValueError,
                               executor._terminate_or_kill_workers,
                               operation='invalid operation'),
 
     @parameterize(*TERMINATE_OR_KILL_PARAMS)
-    def test_process_pool_executor_terminate_kill_workers(self, function_name):
+    def test_terminate_kill_workers(self, function_name):
         manager = self.get_context().Manager()
         q = manager.Queue()
 
@@ -279,7 +279,7 @@ def test_process_pool_executor_terminate_kill_workers(self, function_name):
             self.assertRaises(queue.Empty, q.get, timeout=1)
 
     @parameterize(*TERMINATE_OR_KILL_PARAMS)
-    def test_process_pool_executor_terminate_kill_workers_dead_workers(self, function_name):
+    def test_terminate_kill_workers_dead_workers(self, function_name):
         with futures.ProcessPoolExecutor(max_workers=1) as executor:
             future = executor.submit(os._exit, 1)
             self.assertRaises(BrokenProcessPool, future.result)
@@ -288,7 +288,7 @@ def test_process_pool_executor_terminate_kill_workers_dead_workers(self, functio
             getattr(executor, function_name)()
 
     @parameterize(*TERMINATE_OR_KILL_PARAMS)
-    def test_process_pool_executor_terminate_kill_workers_not_started_yet(self, function_name):
+    def test_terminate_kill_workers_not_started_yet(self, function_name):
         ctx = self.get_context()
         with unittest.mock.patch.object(ctx, 'Process') as mock_process:
             with futures.ProcessPoolExecutor(max_workers=1, mp_context=ctx) as executor:
@@ -300,9 +300,10 @@ def test_process_pool_executor_terminate_kill_workers_not_started_yet(self, func
             mock_process.return_value.terminate.assert_not_called()
 
     @parameterize(*TERMINATE_OR_KILL_PARAMS)
-    def test_process_pool_executor_terminate_kill_workers_stops_pool(self, function_name):
+    def test_terminate_kill_workers_stops_pool(self, function_name):
         with futures.ProcessPoolExecutor(max_workers=1) as executor:
-            executor.submit(time.sleep, 0).result()
+            task = executor.submit(time.sleep, 0)
+            self.assertIsNone(task.result())
 
             getattr(executor, function_name)()
 

Misc/NEWS.d/next/Library/2024-12-17-18-53-21.gh-issue-128041.W96kAr.rst

@@ -1,4 +1,4 @@
-* Add :meth:`concurrent.futures.ProcessPoolExecutor.terminate_workers` and
-  :meth:`concurrent.futures.ProcessPoolExecutor.terminate_workers` as
-  ways to terminate or kill all living worker processes in the given pool.
-  (Contributed by Charles Machalow in :gh:`128043`.)
+Add :meth:`concurrent.futures.ProcessPoolExecutor.terminate_workers` and
+:meth:`concurrent.futures.ProcessPoolExecutor.terminate_workers` as
+ways to terminate or kill all living worker processes in the given pool.
+(Contributed by Charles Machalow in :gh:`128043`.)