Skip to content

Commit dc48587

Browse files
committed
Use default timeout for barrier in test
1 parent dc3a3fe commit dc48587

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

Lib/test/test_concurrent_futures/executor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def test_shutdown_notifies_cancelled_futures(self):
256256

257257
# gh-136655: ensure cancelled futures are notified
258258
count = self.worker_count * 2
259-
barrier = self.create_barrier(self.worker_count + 1)
259+
barrier = self.create_barrier(self.worker_count + 1, timeout=1)
260260
with self.executor as exec:
261261
fs = [exec.submit(blocking_raiser,
262262
barrier if index < self.worker_count else None)
@@ -277,5 +277,5 @@ def test_shutdown_notifies_cancelled_futures(self):
277277

278278
def blocking_raiser(barrier=None):
279279
if barrier is not None:
280-
barrier.wait(1)
280+
barrier.wait()
281281
raise FalseyBoolException()

Lib/test/test_concurrent_futures/util.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ def get_context(self):
8080
class ThreadPoolMixin(ExecutorMixin):
8181
executor_type = futures.ThreadPoolExecutor
8282

83-
def create_barrier(self, count):
84-
return threading.Barrier(count)
83+
def create_barrier(self, count, **kwargs):
84+
return threading.Barrier(count, **kwargs)
8585

8686
def create_event(self):
8787
return threading.Event()
@@ -91,7 +91,7 @@ def create_event(self):
9191
class InterpreterPoolMixin(ExecutorMixin):
9292
executor_type = futures.InterpreterPoolExecutor
9393

94-
def create_barrier(self, count):
94+
def create_barrier(self, count, **kwargs):
9595
self.skipTest("InterpreterPoolExecutor doesn't support barriers")
9696

9797
def create_event(self):
@@ -113,8 +113,8 @@ def get_context(self):
113113
self.skipTest("TSAN doesn't support threads after fork")
114114
return super().get_context()
115115

116-
def create_barrier(self, count):
117-
return self.manager.Barrier(count)
116+
def create_barrier(self, count, **kwargs):
117+
return self.manager.Barrier(count, **kwargs)
118118

119119
def create_event(self):
120120
return self.manager.Event()
@@ -131,8 +131,8 @@ def get_context(self):
131131
self.skipTest("ProcessPoolExecutor unavailable on this system")
132132
return super().get_context()
133133

134-
def create_barrier(self, count):
135-
return self.manager.Barrier(count)
134+
def create_barrier(self, count, **kwargs):
135+
return self.manager.Barrier(count, **kwargs)
136136

137137
def create_event(self):
138138
return self.manager.Event()
@@ -153,8 +153,8 @@ def get_context(self):
153153
self.skipTest("TSAN doesn't support threads after fork")
154154
return super().get_context()
155155

156-
def create_barrier(self, count):
157-
return self.manager.Barrier(count)
156+
def create_barrier(self, count, **kwargs):
157+
return self.manager.Barrier(count, **kwargs)
158158

159159
def create_event(self):
160160
return self.manager.Event()

0 commit comments

Comments
 (0)