Address review

sobolevn · sobolevn · commit deb9223161f0 · 2025-06-24T16:02:29.000+03:00
diff --git a/Objects/namespaceobject.c b/Objects/namespaceobject.c
@@ -124,7 +124,8 @@ namespace_repr(PyObject *ns)
         if (PyUnicode_Check(key) && PyUnicode_GET_LENGTH(key) > 0) {
             PyObject *value, *item;
 
-            if (PyDict_GetItemRef(d, key, &value) == 1) {
+            int has_key = PyDict_GetItemRef(d, key, &value);
+            if (has_key == 1) {
                 item = PyUnicode_FromFormat("%U=%R", key, value);
                 Py_DECREF(value);
                 if (item == NULL) {
@@ -135,7 +136,7 @@ namespace_repr(PyObject *ns)
                     Py_DECREF(item);
                 }
             }
-            else {
+            else if (has_key < 0) {
                 loop_error = 1;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,8 @@ namespace_repr(PyObject *ns)`
`124`	`124`	`if (PyUnicode_Check(key) && PyUnicode_GET_LENGTH(key) > 0) {`
`125`	`125`	`PyObject value, item;`
`126`	`126`
`127`		`- if (PyDict_GetItemRef(d, key, &value) == 1) {`
	`127`	`+ int has_key = PyDict_GetItemRef(d, key, &value);`
	`128`	`+ if (has_key == 1) {`
`128`	`129`	`item = PyUnicode_FromFormat("%U=%R", key, value);`
`129`	`130`	`Py_DECREF(value);`
`130`	`131`	`if (item == NULL) {`
`@@ -135,7 +136,7 @@ namespace_repr(PyObject *ns)`
`135`	`136`	`Py_DECREF(item);`
`136`	`137`	`}`
`137`	`138`	`}`
`138`		`- else {`
	`139`	`+ else if (has_key < 0) {`
`139`	`140`	`loop_error = 1;`
`140`	`141`	`}`
`141`	`142`	`}`