GH-140058: Clear key and value if PyTuple_New fails in dictiter_iternextitem (#140059)

sergey-miryanov · web-flow · commit ded59f7e8e93 · 2025-10-14T18:15:39.000+05:30
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -5719,8 +5719,11 @@ dictiter_iternextitem(PyObject *self)
         }
         else {
             result = PyTuple_New(2);
-            if (result == NULL)
+            if (result == NULL) {
+                Py_DECREF(key);
+                Py_DECREF(value);
                 return NULL;
+            }
             PyTuple_SET_ITEM(result, 0, key);
             PyTuple_SET_ITEM(result, 1, value);
         }

Original file line number	Diff line number	Diff line change
`@@ -5719,8 +5719,11 @@ dictiter_iternextitem(PyObject *self)`
`5719`	`5719`	`}`
`5720`	`5720`	`else {`
`5721`	`5721`	`result = PyTuple_New(2);`
`5722`		`- if (result == NULL)`
	`5722`	`+ if (result == NULL) {`
	`5723`	`+ Py_DECREF(key);`
	`5724`	`+ Py_DECREF(value);`
`5723`	`5725`	`return NULL;`
	`5726`	`+ }`
`5724`	`5727`	`PyTuple_SET_ITEM(result, 0, key);`
`5725`	`5728`	`PyTuple_SET_ITEM(result, 1, value);`
`5726`	`5729`	`}`