Use PyUnicode_FromFormat instead of a buffer

emmatyping · emmatyping · commit e15dd85f3ce9 · 2025-04-28T18:14:13.000-07:00
diff --git a/Modules/_zstd/zdict.c b/Modules/_zstd/zdict.c
@@ -147,12 +147,8 @@ PyDoc_STRVAR(ZstdDict_dictcontent_doc,
 static PyObject *
 ZstdDict_str(ZstdDict *dict)
 {
-    char buf[64];
-    PyOS_snprintf(buf, sizeof(buf),
-                  "<ZstdDict dict_id=%u dict_size=%zd>",
-                  dict->dict_id, Py_SIZE(dict->dict_content));
-
-    return PyUnicode_FromString(buf);
+    return PyUnicode_FromFormat("<ZstdDict dict_id=%u dict_size=%zd>",
+                                dict->dict_id, Py_SIZE(dict->dict_content));
 }
 
 static PyMemberDef ZstdDict_members[] = {

Original file line number	Diff line number	Diff line change
`@@ -147,12 +147,8 @@ PyDoc_STRVAR(ZstdDict_dictcontent_doc,`
`147`	`147`	`static PyObject *`
`148`	`148`	`ZstdDict_str(ZstdDict *dict)`
`149`	`149`	`{`
`150`		`- char buf[64];`
`151`		`- PyOS_snprintf(buf, sizeof(buf),`
`152`		`- "<ZstdDict dict_id=%u dict_size=%zd>",`
`153`		`- dict->dict_id, Py_SIZE(dict->dict_content));`
`154`		`-`
`155`		`- return PyUnicode_FromString(buf);`
	`150`	`+ return PyUnicode_FromFormat("<ZstdDict dict_id=%u dict_size=%zd>",`
	`151`	`+ dict->dict_id, Py_SIZE(dict->dict_content));`
`156`	`152`	`}`
`157`	`153`
`158`	`154`	`static PyMemberDef ZstdDict_members[] = {`