Skip to content

Commit e48e0ea

Browse files
committed
PR feedback wrt timeouts
1 parent 6dec6f4 commit e48e0ea

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Lib/test/test_concurrent_futures/test_process_pool.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def test_force_shutdown_workers(self, function_name):
267267

268268
# We should get started, but not finished since we'll terminate the
269269
# workers just after
270-
self.assertEqual(q.get(timeout=5), 'started')
270+
self.assertEqual(q.get(timeout=support.SHORT_TIMEOUT), 'started')
271271

272272
worker_process = list(executor._processes.values())[0]
273273

@@ -285,7 +285,7 @@ def test_force_shutdown_workers(self, function_name):
285285
else:
286286
self.fail(f"Unknown operation: {function_name}")
287287

288-
self.assertRaises(queue.Empty, q.get, timeout=1)
288+
self.assertRaises(queue.Empty, q.get, timeout=0.01)
289289

290290
@parameterize(*FORCE_SHUTDOWN_PARAMS)
291291
def test_force_shutdown_workers_dead_workers(self, function_name):
@@ -324,7 +324,7 @@ def test_force_shutdown_workers_stops_pool(self, function_name):
324324
# If we don't, every once in a while we may get an ENV CHANGE
325325
# error since the process would be alive immediately after the
326326
# test run.. and die a moment later.
327-
worker_process.join(5)
327+
worker_process.join(support.SHORT_TIMEOUT)
328328

329329
# Oddly enough, even though join completes, sometimes it takes a
330330
# moment for the process to actually be marked as dead.

0 commit comments

Comments
 (0)