Skip to content

Commit e6aa515

Browse files
authored
gh-140009: Improve performance of list_extend_dictitems by using PyTuple_FromArray (#140010)
1 parent 0344db8 commit e6aa515

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Improve performance of list extension by dictionary items.

Objects/listobject.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,9 +1382,9 @@ list_extend_dictitems(PyListObject *self, PyDictObject *dict)
13821382
PyObject **dest = self->ob_item + m;
13831383
Py_ssize_t pos = 0;
13841384
Py_ssize_t i = 0;
1385-
PyObject *key, *value;
1386-
while (_PyDict_Next((PyObject *)dict, &pos, &key, &value, NULL)) {
1387-
PyObject *item = PyTuple_Pack(2, key, value);
1385+
PyObject *key_value[2];
1386+
while (_PyDict_Next((PyObject *)dict, &pos, &key_value[0], &key_value[1], NULL)) {
1387+
PyObject *item = PyTuple_FromArray(key_value, 2);
13881388
if (item == NULL) {
13891389
Py_SET_SIZE(self, m + i);
13901390
return -1;

0 commit comments

Comments
 (0)