100% coverage of find

Author: StanFromIreland

Lib/test/test_gettext.py

@@ -717,13 +717,16 @@ def test_expand_lang(self):
                                          return_value=locale):
                     self.assertEqual(gettext._expand_lang(locale), expanded)
 
+# helper for FindTestCase
+def _clearvars(env):
+    for key in ('LANGUAGE', 'LC_ALL', 'LC_MESSAGES', 'LANG'):
+        env.unset(key)
+
 class FindTestCase(unittest.TestCase):
     def test_find_with_env_vars(self):
         # test that find correctly finds the environment variable LANGUAGE
         # when languages are not supplied
         with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
-            for key in ('LANGUAGE', 'LC_ALL', 'LC_MESSAGES', 'LANG'):
-                env.unset(key)
             env.set('LANGUAGE', 'ga_IE')
 
             locale_dir = os.path.join(tempdir, "locale")
@@ -739,8 +742,7 @@ def test_find_with_env_vars(self):
     def test_find_with_lanuages(self):
         # test that passed languages are used
         with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
-            for key in ('LANGUAGE', 'LC_ALL', 'LC_MESSAGES', 'LANG'):
-                env.set(key, 'pt_BR')
+            env.set('LANGUAGE', 'pt_BR')
 
             locale_dir = os.path.join(tempdir, "locale")
             mofile_dir = os.path.join(locale_dir, "ga_IE", "LC_MESSAGES")
@@ -752,26 +754,47 @@ def test_find_with_lanuages(self):
             result = gettext.find("mofile", localedir=locale_dir, languages=['ga_IE'])
             self.assertEqual(result, mo_file)
 
-    def test_find_with_all(self):
+    def test_find_with_no_lang(self):
+        # no language can be found
+        with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
+            _clearvars(env)
+            result = gettext.find('foo')
+            self.assertEqual(result, None)
+
+    def test_find_with_c(self):
+        # 'C' is already in languages
+        with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
+            env.set('LANGUAGE', 'C')
+            result = gettext.find('foo')
+            self.assertEqual(result, None)
+
+    def test_find_all(self):
         # test that all are returned when all is set
         with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
-            for key in ('LANGUAGE', 'LC_ALL', 'LC_MESSAGES', 'LANG'):
-                env.unset(key)
-            env.set('LANGUAGE', 'ga_IE')
+            _clearvars(env)
 
             locale_dir = os.path.join(tempdir, "locale")
             paths = []
-            for lang in ["ga_IE", "ga"]:
+            for lang in ["ga_IE", "es_ES"]:
                 mofile_dir = os.path.join(locale_dir, lang, "LC_MESSAGES")
                 os.makedirs(mofile_dir)
                 mo_file = os.path.join(mofile_dir, "mofile.mo")
                 with open(mo_file, "wb") as f:
                     f.write(b"\xDE\x12\x04\x95")
                 paths.append(mo_file)
 
-            result = gettext.find('mofile', localedir=locale_dir, all=True)
+            result = gettext.find('mofile', localedir=locale_dir,
+                                  languages=["ga_IE", "es_ES"], all=True)
             self.assertEqual(sorted(result), sorted(paths))
 
+    def test_find_dedupelication(self):
+        # test that find removes duplicate languages
+        with os_helper.EnvironmentVarGuard() as env, os_helper.temp_cwd() as tempdir:
+            _clearvars(env)
+
+            result = gettext.find("foo", languages=['ga_IE', 'ga_IE'])
+            self.assertEqual(result, None)
+
 
 class MiscTestCase(unittest.TestCase):
     def test__all__(self):