Skip to content

Commit ef36eb2

Browse files
committed
Address vstinner review comments.
1 parent 417143e commit ef36eb2

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Doc/library/test.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@ The :mod:`test.support` module defines the following functions:
857857
``musl``, otherwise return a version triple, either ``(0, 0, 0)`` if the
858858
version is unknown, or the actual version if it is known. Intended for use
859859
in ``skip`` decorators. ``emscripten`` and ``wasi`` are assumed to be
860-
compiled with ``musl``; othewise ``platform.libc_ver`` is checked.
860+
compiled with ``musl``; otherwise ``platform.libc_ver`` is checked.
861861

862862

863863
.. function:: check_syntax_error(testcase, statement, errtext='', *, lineno=None, offset=None)

Lib/test/test_math.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2772,8 +2772,8 @@ def test_fma_infinities(self):
27722772
or (sys.platform == "android" and platform.machine() == "x86_64")
27732773
or support.linked_to_musl(), # gh-131032
27742774
f"this platform doesn't implement IEE 754-2008 properly")
2775-
# XXX musl is fixed but the fix is not yet released; when the fixed version
2776-
# is known change this to:
2775+
# gh-131032: musl is fixed but the fix is not yet released; when the fixed
2776+
# version is known change this to:
27772777
# or support.linked_to_musl() < (1, <m>, <p>)
27782778
def test_fma_zero_result(self):
27792779
nonnegative_finites = [0.0, 1e-300, 2.3, 1e300]

Lib/test/test_os.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2563,7 +2563,7 @@ def test_fpathconf(self):
25632563
support.linked_to_musl(),
25642564
'musl pathconf ignores the file descriptor and returns a constant',
25652565
)
2566-
def test_fpathconf_with_bad_fd(self):
2566+
def test_fpathconf_bad_fd(self):
25672567
self.check(os.pathconf, "PC_NAME_MAX")
25682568
self.check(os.fpathconf, "PC_NAME_MAX")
25692569

Lib/test/test_support.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,10 +747,10 @@ def test_get_signal_name(self):
747747
def test_linked_to_musl(self):
748748
linked = support.linked_to_musl()
749749
self.assertIsNotNone(linked)
750-
if support.is_wasi:
750+
if support.is_wasi or support.is_emscripten:
751751
self.assertTrue(linked)
752752
# The value is cached, so make sure it returns the same value again.
753-
self.assertEqual(linked, support.linked_to_musl())
753+
self.assertIs(linked, support.linked_to_musl())
754754
# The unlike libc, the musl version is a triple.
755755
if linked:
756756
self.assertIsInstance(linked, tuple)

0 commit comments

Comments
 (0)