Code review

cdce8p · cdce8p · commit ef84a10cad10 · 2025-10-28T14:32:56.000+01:00
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -802,9 +802,8 @@ _PyEval_MatchClass(PyThreadState *tstate, PyObject *subject, PyObject *type,
         }
         if (match_self) {
             // Easy. Copy the subject itself, and move on to kwargs.
-            Py_NewRef(subject);
             assert(PyTuple_GET_ITEM(attrs, 0) == NULL);
-            PyTuple_SET_ITEM(attrs, 0, subject);
+            PyTuple_SET_ITEM(attrs, 0, Py_NewRef(subject));
         }
         else {
             for (Py_ssize_t i = 0; i < nargs; i++) {

Original file line number	Diff line number	Diff line change
`@@ -802,9 +802,8 @@ _PyEval_MatchClass(PyThreadState tstate, PyObject subject, PyObject *type,`
`802`	`802`	`}`
`803`	`803`	`if (match_self) {`
`804`	`804`	`// Easy. Copy the subject itself, and move on to kwargs.`
`805`		`- Py_NewRef(subject);`
`806`	`805`	`assert(PyTuple_GET_ITEM(attrs, 0) == NULL);`
`807`		`- PyTuple_SET_ITEM(attrs, 0, subject);`
	`806`	`+ PyTuple_SET_ITEM(attrs, 0, Py_NewRef(subject));`
`808`	`807`	`}`
`809`	`808`	`else {`
`810`	`809`	`for (Py_ssize_t i = 0; i < nargs; i++) {`