Move bytes operations out of Py_BEGIN_ALLOW_THREADS

Author: emmatyping

Modules/_zstd/_zstdmodule.c

@@ -250,9 +250,11 @@ _zstd__train_dict_impl(PyObject *module, PyBytesObject *samples_bytes,
     }
 
     /* Train the dictionary */
+    char *dst_dict_buffer = PyBytes_AS_STRING(dst_dict_bytes);
+    char *samples_buffer = PyBytes_AS_STRING(samples_bytes);
     Py_BEGIN_ALLOW_THREADS
-    zstd_ret = ZDICT_trainFromBuffer(PyBytes_AS_STRING(dst_dict_bytes), dict_size,
-                                     PyBytes_AS_STRING(samples_bytes),
+    zstd_ret = ZDICT_trainFromBuffer(dst_dict_buffer, dict_size,
+                                     samples_buffer,
                                      chunk_sizes, (uint32_t)chunks_number);
     Py_END_ALLOW_THREADS
 

Modules/_zstd/compressor.c

@@ -151,9 +151,12 @@ _get_CDict(ZstdDict *self, int compressionLevel)
         }
 
         /* Create ZSTD_CDict instance */
+        char *dict_buffer = PyBytes_AS_STRING(self->dict_content);
+        Py_ssize_t dict_len = Py_SIZE(self->dict_content);
         Py_BEGIN_ALLOW_THREADS
-        cdict = ZSTD_createCDict(PyBytes_AS_STRING(self->dict_content),
-                                 Py_SIZE(self->dict_content), compressionLevel);
+        cdict = ZSTD_createCDict(dict_buffer,
+                                 dict_len,
+                                 compressionLevel);
         Py_END_ALLOW_THREADS
 
         if (cdict == NULL) {

Modules/_zstd/decompressor.c

@@ -36,9 +36,11 @@ _get_DDict(ZstdDict *self)
     Py_BEGIN_CRITICAL_SECTION(self);
     if (self->d_dict == NULL) {
         /* Create ZSTD_DDict instance from dictionary content */
+        char *dict_buffer = PyBytes_AS_STRING(self->dict_content);
+        Py_ssize_t dict_len = Py_SIZE(self->dict_content);
         Py_BEGIN_ALLOW_THREADS
-        self->d_dict = ZSTD_createDDict(PyBytes_AS_STRING(self->dict_content),
-                                        Py_SIZE(self->dict_content));
+        self->d_dict = ZSTD_createDDict(dict_buffer,
+                                        dict_len);
         Py_END_ALLOW_THREADS
 
         if (self->d_dict == NULL) {