Test Path.parts instead of private _raw_path property

Author: colesbury

Lib/test/test_pathlib/test_join.py

@@ -3,6 +3,8 @@
 """
 
 import unittest
+import threading
+from test.support import threading_helper
 
 from .support import is_pypi
 from .support.lexical_path import LexicalPath
@@ -158,6 +160,26 @@ def test_parts(self):
         parts = p.parts
         self.assertEqual(parts, (sep, 'a', 'b'))
 
+    @threading_helper.requires_working_threading()
+    def test_parts_multithreaded(self):
+        P = self.cls
+
+        NUM_THREADS = 10
+        NUM_ITERS = 10
+
+        for _ in range(NUM_ITERS):
+            b = threading.Barrier(NUM_THREADS)
+            path = P('a') / 'b' / 'c' / 'd' / 'e'
+            expected = ('a', 'b', 'c', 'd', 'e')
+
+            def check_parts():
+                b.wait()
+                self.assertEqual(path.parts, expected)
+
+            threads = [threading.Thread(target=check_parts) for _ in range(NUM_THREADS)]
+            with threading_helper.start_threads(threads):
+                pass
+
     def test_parent(self):
         # Relative
         P = self.cls

Lib/test/test_pathlib/test_pathlib.py

@@ -11,7 +11,6 @@
 import socket
 import stat
 import tempfile
-import threading
 import unittest
 from unittest import mock
 from urllib.request import pathname2url
@@ -21,7 +20,6 @@
 from test.support import is_emscripten, is_wasi, is_wasm32
 from test.support import infinite_recursion
 from test.support import os_helper
-from test.support import threading_helper
 from test.support.os_helper import TESTFN, FS_NONASCII, FakePath
 try:
     import fcntl
@@ -1100,27 +1098,6 @@ def test_is_relative_to_windows(self):
         self.assertFalse(p.is_relative_to(P('//z/Share/Foo')))
         self.assertFalse(p.is_relative_to(P('//Server/z/Foo')))
 
-    @threading_helper.requires_working_threading()
-    def test_raw_path_multithread(self):
-        P = self.cls
-        sep = self.sep
-
-        NUM_THREADS = 10
-        NUM_ITERS = 10
-
-        for _ in range(NUM_ITERS):
-            b = threading.Barrier(NUM_THREADS)
-            path = P('a') / 'b' / 'c' / 'd' / 'e'
-            expected = sep.join(['a', 'b', 'c', 'd', 'e'])
-
-            def check_raw_path():
-                b.wait()
-                self.assertEqual(path._raw_path, expected)
-
-            threads = [threading.Thread(target=check_raw_path) for _ in range(NUM_THREADS)]
-            with threading_helper.start_threads(threads):
-                pass
-
 
 class PurePosixPathTest(PurePathTest):
     cls = pathlib.PurePosixPath