Skip to content

Commit fe9971c

Browse files
Address comments about backend
1 parent 7c83425 commit fe9971c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Lib/bdb.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,10 @@ def __init__(self, skip=None, backend='settrace'):
217217
self.backend = backend
218218
if backend == 'monitoring':
219219
self.monitoring_tracer = _MonitoringTracer()
220-
else:
220+
elif backend == 'settrace':
221221
self.monitoring_tracer = None
222+
else:
223+
raise ValueError(f"Invalid backend '{backend}'")
222224

223225
self._load_breaks()
224226

@@ -240,13 +242,13 @@ def canonic(self, filename):
240242
return canonic
241243

242244
def start_trace(self, trace_dispatch):
243-
if self.backend == 'monitoring':
245+
if self.monitoring_tracer:
244246
self.monitoring_tracer.start_trace(trace_dispatch)
245247
else:
246248
sys.settrace(self.trace_dispatch)
247249

248250
def stop_trace(self):
249-
if self.backend == 'monitoring':
251+
if self.monitoring_tracer:
250252
self.monitoring_tracer.stop_trace()
251253
else:
252254
sys.settrace(None)
@@ -532,7 +534,7 @@ def _set_trace_opcodes(self, trace_opcodes):
532534
frame = self.enterframe
533535
while frame is not None:
534536
frame.f_trace_opcodes = trace_opcodes
535-
if self.backend == 'monitoring':
537+
if self.monitoring_tracer:
536538
self.monitoring_tracer.set_trace_opcodes(frame, trace_opcodes)
537539
if frame is self.botframe:
538540
break

0 commit comments

Comments
 (0)