Compiling 3.13 in MSYS2/UCRT64 causes a type error for _PyTime_AsTime_t

[Paebbels]

Bug report

Bug description:

Compiling Python 3.13 on MSYS2/UCRT64 causes a type check error for _PyTime_AsTime_t's second parameter.

Python/pytime.c: In function 'pytime_as_timeval_struct':
Python/pytime.c:815:37: error: passing argument 2 of '_PyTime_AsTime_t' from incompatible pointer type [-Wincompatible-pointer-types]
  815 |     res2 = _PyTime_AsTime_t(tv_sec, &tv->tv_sec);
      |                                     ^~~~~~~~~~~
      |                                     |
      |                                     long int *
Python/pytime.c:245:38: note: expected 'time_t *' {aka 'long long int *'} but argument is of type 'long int *'
  245 | _PyTime_AsTime_t(PyTime_t t, time_t *t2)
      |                              ~~~~~~~~^~

How to reproduce:
Environment: MSYS2/UCRT64
Commit: 4aa0c5e (origin/3.13, 3.13)

CXX=g++ ./configure --disable-gil --enable-optimizations --with-lto=full --with-ensurepip=install
make -j16

CPython versions tested on:

• 3.12
• 3.13

Operating systems tested on:

Windows

Linked PRs

• gh-121427: Fixed type errors triggered when compiling with MSYS2/UCRT64 #126355

[serhiy-storchaka]

cc @vstinner

[vstinner]

Do you want to propose a PR to fix the issue?

MSYS2 is not platform supported by PEP 11, but if you provide a fix, I can review it.

[rruuaanng]

I've raised a PR for this issue, if you don't mind :)

[vstinner]

Environment: MSYS2/UCRT64

Is the MS_WINDOWS macro defined on this environment?

There is a code path for Windows using _PyTime_AsCLong():

#ifdef MS_WINDOWS
    // On Windows, timeval.tv_sec type is long
    res2 = _PyTime_AsCLong(tv_sec, &tv->tv_sec);
#else
    res2 = _PyTime_AsTime_t(tv_sec, &tv->tv_sec);  // <=== Line 815
#endif

[zooba]

Would a sizeof(tv->tv_sec) test be better than an MS_WINDOWS test here?