How to get msecs from PyTime API in 3.13?

[tonybaloney]

Bug report

Bug description:

In 3.12 and below, with a _Py_Time handle I could get the milliseconds for a time struct:

msecs = _PyTime_AsMilliseconds(ctime, _PyTime_ROUND_CEILING);

The _PyTime_AsMilliseconds API has moved to the internal API so is no longer importable from an extension module. The new C APi for PyTime doesn't include an msecs conversion method, what should we use?

Thanks,

CPython versions tested on:

3.13

Operating systems tested on:

Linux, macOS, Windows

[vstinner]

In Python 3.13, I added 7 PyTime functions to the public C API: https://docs.python.org/dev/c-api/time.html

You're right that other functions have been moved to the internal C API. A workaround is to use the internal C API: <pycore_time.h> which exposes _PyTime_AsMilliseconds() function.

If you want to expose this function to the public C API, you should expose your use case, explain why you need it, etc. Which projects are used it?

[vstinner]

Did you find a workaround in the meanwhile?

[vstinner]

msecs = _PyTime_AsMilliseconds(ctime, _PyTime_ROUND_CEILING);

The PyTime_t type is a number of nanoseconds, you can reimplement this code using:

msecs = (ctime + 1000000 - 1) / 1000000;

This issue has no activity since September. Should we close it? Do you still need this function?

[tonybaloney]

I think the manual calculation does what we need. Thanks & Closing.