http.server.BaseHTTPRequestHandler.parse_request func has bug!!!

[Firebasky]

Bug report

Bug description:

# Add a code block here, if required

in:https://github.com/python/cpython/blob/main/Lib/http/server.py#L307
If the requested version is HTTP/2, there will be an exception.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

[rruuaanng]

Bug report

Bug description:

# Add a code block here, if required

in:https://github.com/python/cpython/blob/main/Lib/http/server.py#L307 If the requested version is HTTP/2, there will be an exception.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Maybe you should show the error codefile.
And when writing issue titles, please skip any symbols that don’t relate to the content. thanks.

[skirpichev]

If the requested version is HTTP/2, there will be an exception.

Is this a legal string?

[skirpichev]

Quote RFC 2145:

      HTTP uses a "<major>.<minor>" numbering scheme to indicate
      versions of the protocol. The protocol versioning policy is
      intended to allow the sender to indicate the format of a message
      and its capacity for understanding further HTTP communication,
      rather than the features obtained via that communication.  No
      change is made to the version number for the addition of message
      components which do not affect communication behavior or which
      only add to extensible field values.  The <minor> number is
      incremented when the changes made to the protocol add features
      which do not change the general message parsing algorithm, but
      which may add to the message semantics and imply additional
      capabilities of the sender. The <major> number is incremented when
      the format of a message within the protocol is changed."

It doesn't say that either part is optional.

I don't think it's a bug.

[Firebasky]

Bug report

Bug description:

# Add a code block here, if required

in:https://github.com/python/cpython/blob/main/Lib/http/server.py#L307 If the requested version is HTTP/2, there will be an exception.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Maybe you should show the error codefile. And when writing issue titles, please skip any symbols that don’t relate to the content. thanks.

i got it.

[Firebasky]

I encountered an error while parsing the complete HTTP request packet using the parse_dequest function.

from http.server import BaseHTTPRequestHandler
from io import BytesIO

class BareLoader(BaseHTTPRequestHandler):

    def __init__(self, request_bin):
        self.rfile = BytesIO(request_bin)
        self.raw_requestline = self.rfile.readline()
        self.error_code = self.error_message = None
        self.parse_request()

a = '''POST /test HTTP/2
Host: localhost
Accept: application/json, text/plain, */*
Content-Type: application/x-www-form-urlencoded

data=test'''
loader = BareLoader(a.encode())
print(loader.headers)

If it is the following code, there will be no exception

from http.server import BaseHTTPRequestHandler
from io import BytesIO

class BareLoader(BaseHTTPRequestHandler):

    def __init__(self, request_bin):
        self.rfile = BytesIO(request_bin)
        self.raw_requestline = self.rfile.readline()
        self.error_code = self.error_message = None
        self.parse_request()

a = '''POST /test HTTP/1.1
Host: localhost
Accept: application/json, text/plain, */*
Content-Type: application/x-www-form-urlencoded

data=test'''
loader = BareLoader(a.encode())
print(loader.headers)

So I think the parse_dequest function did not take into account the http2 protocol

[skirpichev]

POST /test HTTP/2

@Firebasky, could you please point to RFC, which permits such query?

[rruuaanng]

POST /test HTTP/2

@Firebasky, could you please point to RFC, which permits such query?

I think this issue can be close.

Above img from RFC7540.

Frame format

Above img from RFC9113.

So, obviously HTTP/2 request messages do not allow the use of ASCII.

[skirpichev]

Ok, RFC for HTTP-Version in the Request-Line was quoted above.

I'm going to close this, unless OP will find a standard, which permit to omit minor version in HTTP/2.