-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Description
Feature or enhancement
Proposal:
Current recommendation for spec=...
and create_autospec
is to set a default class value in case of attributes created within an instance's __init__()
:
Probably the best way of solving the problem is to add class attributes as default values for instance members initialised in
__init__()
The problem is that like written, None
s are never useful and together with spec_set=True
it just results in a regular mock that accepts everything.
That recommendation and method are unfortunately very old and they existed long before the type hinting system was so developed. I believe type hints can now be reliably used to infer the spec, at least in simple terms, and in the other cases the same behavior as None
can be implemented.
from unittest.mock import create_autospec
class A:
a: dict[str, int]
b: Iterator[str]
c: int | str | complex
mock = create_autospec(A)
mock().a # should be supported, with a dict spec.
mock().b # Iterator spec
mock().c # Too complex... Any spec (just like current behavior for None)
It will lead into more accurate unit tests, and we can optionally hide the behavior behind a boolean such as infer_types=True
.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Metadata
Metadata
Assignees
Labels
Projects
Status