-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Closed
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement
Description
Feature or enhancement
Proposal:
In getopt
and optparse
, there are import guards around gettext
:
Lines 37 to 41 in 556dc9b
try: | |
from gettext import gettext as _ | |
except ImportError: | |
# Bootstrapping Python: gettext's dependencies not built yet | |
def _(s): return s |
Lines 89 to 100 in 556dc9b
try: | |
from gettext import gettext, ngettext | |
except ImportError: | |
def gettext(message): | |
return message | |
def ngettext(singular, plural, n): | |
if n == 1: | |
return singular | |
return plural | |
_ = gettext |
Based on the original issue that added these, importing gettext
directly used to cause some build issues. This does not seem to be the case anymore at least on Linux for me. I'll send a PR to see if any other platforms fail.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
ZeroIntensity
Metadata
Metadata
Assignees
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement