Tcl warnings while building latest main -

[srinivasreddy]

Bug report

Bug description:

I am building the latest main at 48c70b8 , with ./configure and make commands. These are the warnings i have seen in the console. I have seen some other warnings too, for them i have raised another issue #128086. Looks like these are related to Tcl/tk, hence new issue.

In file included from /usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  131 |         int (*free_private)();  /* called to free private storage */
      |                            ^
      |                             void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  334 |         struct _XImage *(*create_image)();
      |                                        ^
      |                                         void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  453 |         XID (*resource_alloc)(); /* allocator function */
      |                              ^
      |                               void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  471 |         int (*synchandler)();   /* Synchronization handler */
      |                           ^
      |                            void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  496 |         Bool (*event_vec[128])();  /* vector for wire to event */
      |                               ^
      |                                void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  497 |         Status (*wire_vec[128])(); /* vector for event to wire */
      |                                ^
      |                                 void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  509 |         Bool (**error_vec)();      /* vector for wire to error */
      |                           ^
      |                            void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  522 |         int (*savedsynchandler)(); /* user synchandler when Xlib usurps */
      |                                ^
      |                                 void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
 1053 | typedef void (*XIMProc)();
      |                        ^
      |                         void
9 warnings generated.
gcc -I/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk -Wno-strict-prototypes -DWITH_APPINIT=1 -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include     -c ./Modules/tkappinit.c -o Modules/tkappinit.o
In file included from ./Modules/tkappinit.c:17:
In file included from /usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  131 |         int (*free_private)();  /* called to free private storage */
      |                            ^
      |                             void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  334 |         struct _XImage *(*create_image)();
      |                                        ^
      |                                         void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  453 |         XID (*resource_alloc)(); /* allocator function */
      |                              ^
      |                               void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  471 |         int (*synchandler)();   /* Synchronization handler */
      |                           ^
      |                            void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  496 |         Bool (*event_vec[128])();  /* vector for wire to event */
      |                               ^
      |                                void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  497 |         Status (*wire_vec[128])(); /* vector for event to wire */
      |                                ^
      |                                 void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  509 |         Bool (**error_vec)();      /* vector for wire to error */
      |                           ^
      |                            void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  522 |         int (*savedsynchandler)(); /* user synchandler when Xlib usurps */
      |                                ^
      |                                 void
/usr/local/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
 1053 | typedef void (*XIMProc)();
      |                        ^
      |                         void
9 warnings generated.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

[srinivasreddy]

I have updated the tcl-tk to version 9.0.0_1, the warnings are gone. Please refer - build.log

[terryjreedy]

Is not this the responsibility of the tcl/tk folks? Or do you think we should do some sort of local patch or workaround?

[picnixz]

Some additional context: we had some CI issues on macOS with tcl/tk 9 recently (see #127359) and updated to 8.6.x recently (#124448). I haven't checked if our configure script pins the Tcl version to some explicit version or just uses the latest one.

---

And yes, IMO it should be a tcl/tk issue (if we don't want to upgrade the minimal tcl version, then it's likely better to post on their bug tracker)

[picnixz]

I'm closing this one as wont fix as we're currently pinning Tcl/Tk to version 8.x instead of 9.x, at least on the CI. For custom builds, I don't think we can do anything (namely, pinning the dependency during configure is not a good idea).