Parse int for lltrace

[WolframAlph]

Feature or enhancement

Proposal:

Addressing TODOs when getting lltrace env var:

cpython/Python/ceval.c

Line 249 in bb9d955

lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that

cpython/Python/optimizer_analysis.c

Line 45 in bb9d955

lltrace = *uop_debug - '0'; // TODO: Parse an int and all that

cpython/Python/optimizer_symbols.c

Line 41 in bb9d955

lltrace = *uop_debug - '0'; // TODO: Parse an int and all that

cpython/Python/optimizer.c

Line 571 in bb9d955

lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that

cpython/Python/optimizer.c

Line 1197 in bb9d955

lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

• gh-128394: Parse int for lltrace #128395

[serhiy-storchaka]

I do not think this properly addresses the TODOs. How does it work if the value is not a number? If it starts with 0 or 0x?

Proper fix should check for errors and reject non-decimals. If the code is performance sensitive, it should use fast paths (if the value is dynamic) or caching. Since it is an experimental code added only 1.5 years ago (51fc725), we can wait more time before polishing it.

cc @gvanrossum

[gvanrossum]

I'm sorry, this is not something that needs to be fixed. I am pretty much the only user and python needs to be compiled with an undocumented -D flag for this code to be compiled. The TODO lines were purely for myself. Sorry again.