devcontainer trying to install "/usr/bin/setfacl" under onCreateCommand

[kalikaruto]

Bug report

Bug description:

I was trying to run devcontainer in vs code locally.
Found a line "/usr/bin/setfacl" in

"onCreateCommand": [
        // Install common tooling.
        "dnf",
        "install",
        "-y",
        "which",
        "zsh",
        "fish",
        // For umask fix below.
        "/usr/bin/setfacl"
    ]

which gave me some errors

/sudo: setfacl: command not found


[241733 ms] umask fix: /tmp of postCreateCommand from devcontainer.json failed with exit code 1. Skipping any further user-provided commands.

sudo: setfacl: command not found


[241734 ms] umask fix: workspace of postCreateCommand from devcontainer.json failed with exit code 1. Skipping any further user-provided commands.
Done. Press any key to close the terminal.

I tried to gpt to know what was wrong, and it suggested me to update "/usr/bin/setfacl" to "acl" and it worked. If this was really an issue (because I don't think we can install using path; if that was intended), can I resolve this issue?

I am a beginner to open source and was trying my hand at CPython; thanks for the documentation for beginners—it is really helpful.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

• gh-133737: Installed 'acl' package to ensure setfacl is available #133755

[sobolevn]

Please, send a PR :)

[kalikaruto]

I tried to commit but pre-commit failed, giving

 Building wheels for collected packages: check-jsonschema, regress, rpds-py
      Building wheel for check-jsonschema (pyproject.toml): started
      Building wheel for check-jsonschema (pyproject.toml): finished with status 'done'
      Created wheel for check-jsonschema: filename=check_jsonschema-0.33.0-py3-none-any.whl size=273270 sha256=cab57c5eba5c206a9408f3dd6efe6ff9f2f37a34486e211a83c0ba75d70af4cc
      Stored in directory: /tmp/pip-ephem-wheel-cache-8l7d_xlb/wheels/fe/e4/a5/dd3a140f6b2e85089216c514dde6e3620cb87f7baad0c078c3
      Building wheel for regress (pyproject.toml): started
      Building wheel for regress (pyproject.toml): finished with status 'error'
      Building wheel for rpds-py (pyproject.toml): started
      Building wheel for rpds-py (pyproject.toml): finished with status 'error'
    Successfully built check-jsonschema
    Failed to build regress rpds-py
stderr:
      error: subprocess-exited-with-error
      
      × Building wheel for regress (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [89 lines of output]

and

 --- stderr
            error: the configured Python interpreter version (3.15) is newer than PyO3's maximum supported version (3.13)
            = help: please check if an updated version of PyO3 is available. Current version: 0.24.0
            = help: set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 to suppress this check and build anyway using the stable ABI
          warning: build failed, waiting for other jobs to finish...
          💥 maturin failed
            Caused by: Failed to build a native library through cargo
            Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_ENVIRONMENT_SIGNATURE="cpython-3.15-64bit" PYO3_PYTHON="/root/.cache/pre-commit/repo3uht2kzw/py_env-python3.15/bin/python" PYTHON_SYS_EXECUTABLE="/root/.cache/pre-commit/repo3uht2kzw/py_env-python3.15/bin/python" "cargo" "rustc" "--features" "pyo3/extension-module" "--message-format" "json-render-diagnostics" "--manifest-path" "/tmp/pip-install-80apui8x/rpds-py_d6396dcd72be401f8b7cfd5ecbe30f9d/Cargo.toml" "--release" "--lib"`
          Rust not found, installing into a temporary directory
          Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/root/.cache/pre-commit/repo3uht2kzw/py_env-python3.15/bin/python', '--compatibility', 'off'] returned non-zero exit status 1
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
      ERROR: Failed building wheel for rpds-py
    ERROR: Failed to build installable wheels for some pyproject.toml based projects (regress, rpds-py)
Check the log at /root/.cache/pre-commit/pre-commit.log

what i understand is cpython is at 3.15 but because pyo3 is compatible with only 3.13; hence this doesnt work.
But i dont get why does latest is depending on previous versions.

guidance needed

[kalikaruto]

after some time of gpting and all; figured below worked

export PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1
pre-commit run --all-files

i did this only because i just changed devcontainder
hope this doesnt break cpython😅

[brettcannon]

I can't reproduce the problem when using a GitHub Codespace or locally in VS Code. I think there was a hiccup when you tried to build your container image as that command; the error you shared wasn't from the installation which is what your PR is trying to change. What OS are you using?

Plus using the path to have DNF figure out what to install is accurate and what Fedora maintainers suggested I use to make this work.

So I'm going to close this, but if you need more help we can try and figure out what went wrong.

[kalikaruto]

i was using arch linux;

dnf install /usr/bin/rpmsign
Install a package that provides the /usr/bin/rpmsign file.

i red the doc of dnf and found that we could install using path but can we come up with a reason why it failed for me.
and reading though the error, it says setfacl not found so i think it didn't install setfacl (i wonder why).

my system:

                   -`                    karuto@archlinux 
                  .o+`                   ---------------- 
                 `ooo/                   OS: Arch Linux x86_64 
                `+oooo:                  Host: 82TS Lenovo V14 G3 IAP 1 
               `+oooooo:                 Kernel: 6.14.5-arch1-1 
               -+oooooo+:                Uptime: 17 mins 
             `/:-:++oooo+:               Packages: 1493 (pacman), 13 (flatpak) 
            `/++++/+++++++:              Shell: bash 5.2.37 
           `/++++++++++++++:             Resolution: 1920x1080 
          `/+++ooooooooooooo/`           DE: Plasma 6.3.5 
         ./ooosssso++osssssso+`          WM: KWin 
        .oossssso-````/ossssss+`         Theme: Breeze-Dark [GTK2], Breeze [GTK3] 
       -osssssso.      :ssssssso.        Icons: breeze-dark [GTK2/3] 
      :osssssss/        osssso+++.       Terminal: konsole 
     /ossssssss/        +ssssooo/-       CPU: 12th Gen Intel i5-1235U (12) @ 4.400GHz 
   `/ossssso+/:-        -:/+osssso+-     GPU: Intel Alder Lake-UP3 GT2 [UHD Graphics] 
  `+sso+:-`                 `.-/+oso:    Memory: 4249MiB / 7659MiB 
 `++:.                           `-/+/
 .`                                 `/                           
                                                                 

also i also didnt get why running the pre-commit failed with the error

     error: the configured Python interpreter version (3.15) is newer than PyO3's maximum supported version (3.13)

but after running below it worked

export PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1
pre-commit run --all-files

[brettcannon]

Python has nothing to build using PyO3 nor pre-commit, so I think you have something else going on when you're trying to use the dev container.