Skip to content

Code Review Session for Long-Running Pull Requests #134499

@ShengDong207

Description

@ShengDong207

Team Review Session for Long-Running Pull Requests

We need to organize a code review session to address several long-running pull requests in the cpython repository.

Pull Requests to Review

Based on the long-running PRs in our repository, we should focus on the following:

  1. PR gh-94543: Clarify the mkstemp documentation #107033: "Clarification on how to clean up tempfile.mkstemp #94543: Clarify the mkstemp documentation" (open since July 2023)
  2. PR gh-88629: Add support for Samesite attribute in cookiejar #105425: "HTTP Cookiejar doesn't support samesite #88629: Add support for Samesite attribute in cookiejar" (open since June 2023)
  3. PR Match docstring and args for posixpath.join and ntpath.join #104478: "Match docstring and args for posixpath.join and ntpath.join" (open since May 2023)
  4. PR gh-89519: Emit a warning when classmethod() wraps a non-callable descriptor #92426: "Calling help executes @classmethod @property decorated methods #89519: Emit a warning when classmethod() wraps a non-callable descriptor" (open since May 2022)
  5. PR Makefile: have "install" depend on pgo #95287: "Makefile: have "install" depend on pgo" (open since July 2022)
  6. PR gh-107689: add docstrings to abstract classes #108882: "ctypes: Add docstring for ctypes.Array #107689: add docstrings to abstract classes" (open since September 2023)
  7. PR gh-107620: allow argparse suppression to work via set_defaults() #107621: "argparse does not correctly handle a default set to SUPPRESS when using set_defaults() #107620: allow argparse suppression to work via set_defaults()" (open since August 2023)
  8. PR gh-52188: emit FutureWarning for negative start/end indices #107105: "re.finditer and re.findall should support negative end positions #52188: emit FutureWarning for negative start/end indices" (open since July 2023)

Proposed Agenda

  1. Review status of each PR
  2. Identify blockers or missing reviews
  3. Prioritize and assign PRs for immediate attention
  4. Set deadlines for feedback

Please come prepared having looked at the PRs beforehand. Let's focus on clearing this backlog and improving our review process going forward.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions