-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Open
Labels
extension-modulesC modules in the Modules dirC modules in the Modules dirperformancePerformance or resource usagePerformance or resource usagetype-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
Description
Bug report
Bug description:
csv.writer
does a lot of manual buffer manipulations:
Line 1115 in f58a7c7
join_reset(WriterObj *self) Line 1127 in f58a7c7
join_append_data(WriterObj *self, int field_kind, const void *field_data, Line 1221 in f58a7c7
join_check_rec_size(WriterObj *self, Py_ssize_t rec_len) Line 1240 in f58a7c7
join_append(WriterObj *self, PyObject *field, int quoted) Line 1283 in f58a7c7
join_append_lineterminator(WriterObj *self)
I believe that big parts of this is no longer needed, since 3.14 and introduction of PyUnicodeWriter
:
gh-125196 seems to be a catch-all for using the new API but I believe it's missing the csv
module.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
Metadata
Metadata
Assignees
Labels
extension-modulesC modules in the Modules dirC modules in the Modules dirperformancePerformance or resource usagePerformance or resource usagetype-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)