-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Closed
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
I searched code base and issue seems its a typo in error message
strinq -> string
diff --git a/Lib/pickletools.py b/Lib/pickletools.py
index bcddfb722b..254b6c7fcc 100644
--- a/Lib/pickletools.py
+++ b/Lib/pickletools.py
@@ -348,7 +348,7 @@ def read_stringnl(f, decode=True, stripquotes=True, *, encoding='latin-1'):
for q in (b'"', b"'"):
if data.startswith(q):
if not data.endswith(q):
- raise ValueError("strinq quote %r not found at both "
+ raise ValueError("string quote %r not found at both "
"ends of %r" % (q, data))
data = data[1:-1]
break
diff --git a/Lib/test/test_pickletools.py b/Lib/test/test_pickletools.py
index a178d3353e..cf99087462 100644
--- a/Lib/test/test_pickletools.py
+++ b/Lib/test/test_pickletools.py
@@ -384,13 +384,13 @@ def test_string_without_quotes(self):
self.check_dis_error(b'Sabc"\n.', '',
"no string quotes around b'abc\"'")
self.check_dis_error(b"S'abc\n.", '',
- '''strinq quote b"'" not found at both ends of b"'abc"''')
+ '''string quote b"'" not found at both ends of b"'abc"''')
self.check_dis_error(b'S"abc\n.', '',
- r"""strinq quote b'"' not found at both ends of b'"abc'""")
+ r"""string quote b'"' not found at both ends of b'"abc'""")
self.check_dis_error(b"S'abc\"\n.", '',
- r"""strinq quote b"'" not found at both ends of b'\\'abc"'""")
+ r"""string quote b"'" not found at both ends of b'\\'abc"'""")
self.check_dis_error(b"S\"abc'\n.", '',
- r"""strinq quote b'"' not found at both ends of b'"abc\\''""")
+ r"""string quote b'"' not found at both ends of b'"abc\\''""")
def test_binstring(self):
self.check_dis(b"T\x03\x00\x00\x00abc.", '''\
CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS
Linked PRs
- gh-139646: fix typo in pickletools error message #139647
- [3.14] gh-139646: fix typo in
pickletools
error message (GH-139647) #139649 (backport held until 3.14.0 is released) - [3.13] gh-139646: fix typo in
pickletools
error message (GH-139647) #139650 (backport held until 3.13.8 is released)
Metadata
Metadata
Assignees
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Projects
Status
Done